-
Notifications
You must be signed in to change notification settings - Fork 420
feat(react-shadcn): add new renderer, react-shadcn #2541
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
dclark27
wants to merge
10
commits into
eclipsesource:master
Choose a base branch
from
dclark27:feature/shadcn-renderer
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ Deploy Preview for jsonforms-examples failed.
|
|
|
Author
|
I'll fix up the build issues once I get some feedback |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi all! I have been working the last week on matching parity with vanilla-renderers (and some features from mui-renderers) that are shadcn compatible.
We've used jsonforms since 2024 at Socotra, and have been rendering using a superset of the vanilla-renderers to achieve shadcn styles since then. To reduce complexity on our end, and to help the broader community, I've taken it on myself to bring these changes we've used in production for several years now to you all.
Obviously we'll need to take time to review this, but I've tested using the examples repo and hit as many cases as I could squeeze in this first iteration. I am deeply familiar with the framework and was able to use Claude Code to take the approach I've been meaning to write on my own since taking on our internal form library.
We'll also need documentation updates, more tests, and perhaps a few changes to this existing implementation.
Putting this up as I have it now to gather feedback and hopefully find a path to merging!
Some screens: