Add AbortablePromise#2215
Merged
Merged
Conversation
31d52a2 to
83b30fe
Compare
83b30fe to
8c8c0c0
Compare
An AbortablePromise is a native promise which is abortable. If it is not aborted it is resolved/rejected like a native promise. If it is aborted it is rejected with a CancelError. With this, one can distinguish between the promise being rejected because of an error or because it was aborted due to e.g. user interaction. Move CancelError to scout.rt and rename it to AbortError. 463545 Assisted-by: Sonnet 4.6, Haiku 4.5 (Claude Code)
8c8c0c0 to
e6aef2c
Compare
cguglielmo
approved these changes
Jun 9, 2026
gabrielstalder
approved these changes
Jun 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An AbortablePromise is a native promise which is abortable. If it is not aborted it is resolved/rejected like a native promise. If it is aborted it is rejected with a CancelError. With this, one can distinguish between the promise being rejected because of an error or because it was aborted due to e.g. user interaction.
Move CancelError to scout.rt.
463545
Assisted-by: Sonnet 4.6, Haiku 4.5 (Claude Code)