Add org.eclipse.debug.terminal bundle to org.eclipse.terminal.feature

[iloveeclipse]

Fixes #2423

[laeubi]

As mentioned this bundles does not belongs to the platform.terminal feature.

This does (as the name indicates) belong to eclipse.debug part.

[laeubi]

As a side note: It is not required to have an issue + PR (and if then likely one want to have at least a basic PR description instead of just "fixes XYZ")

[iloveeclipse]

As mentioned this bundles does not belongs to the platform.terminal feature.

This does (as the name indicates) belong to eclipse.debug part.

Well, why shouldn't be Terminal related bundle be part of the Terminal feature? Do you really want to add this bundle to the org.eclipse.platform feature which includes generic debug plugins? This makes less sense in my understanding as to include Terminal specific (debug related) bundle to Terminal feature.

[laeubi]

Well, why shouldn't be Terminal related bundle be part of the Terminal feature?

See #2423 (comment) in general it might be easier to discuss at one place.

Beside that, just compare the dependency closure before and after the addition of that bundle.

Do you really want to add this bundle to the org.eclipse.platform feature which includes generic debug plugins?

I don't want to add it anywhere (now) as it can be easily installed by anyone who is interested in this feature as a standalone bundle.

This makes less sense in my understanding as to include Terminal specific (debug related) bundle to Terminal feature.

If we later find it is extremely useful one might add it to the platform feature, or create an own feature or ... until now it is an option but no one is obliques to use that and its not part of any EPP until now as far as I know nor of the SDK.

[github-actions]

Test Results

 1 977 files  ±0   1 977 suites  ±0   1h 36m 3s ⏱️ + 3m 38s
 4 743 tests ±0   4 719 ✅ ±0   24 💤 ±0  0 ❌ ±0 
14 229 runs  ±0  14 047 ✅ ±0  182 💤 ±0  0 ❌ ±0 

Results for commit 3baa3a7. ± Comparison against base commit 9d41ea7.

[iloveeclipse]

I don't want to add it anywhere (now) as it can be easily installed by anyone who is interested in this feature as a standalone bundle.

How?

I've tried to follow https://github.com/eclipse-platform/www.eclipse.org-eclipse/blob/master/news/4.37/platform.md#support-for-launching-a-run-inside-a-terminal-session but there is no "Terminal Session Support" feature:

[laeubi]

It is included here https://github.com/eclipse-platform/eclipse.platform.releng.aggregator/blob/97792fd0512bf261b5e4fd71bdb521ec5ef8ebb9/sites/eclipse-platform-repository/category.xml#L42 and was installable at the time where I wrote the N&N entry.

I also can see it with repository explorer

The latest change I can see is that it was changed how the update-site is build, maybe something was lost there ( @HannesWell ? ) and now P2 do not recognize it anymore as a root unit that can be installed...

[HannesWell]

The latest change I can see is that it was changed how the update-site is build, maybe something was lost there ( @HannesWell ? ) and now P2 do not recognize it anymore as a root unit that can be installed...

Actually nothing should have changed content-wise, at least it wasn't intended. And as you showed, the bundle is still in the repo.
But I wonder how one can generally install single bundles directly via the P2 UI? Until know I thought only features could be installed? I don't know if assigning a category would make a difference?
But if it has ever worked, then through some means I haven't been aware of until now.

[laeubi]

But I wonder how one can generally install single bundles directly via the P2 UI, Until know I thought only features could be installed?

You can install anything that is an IU, including bundles, e.g. m2e Update site is another example where we select bundles by a filter.

I don't know if assigning a category would make a difference?

Funny enough if one enables "Group items by category" it is shown under the "Uncategorized" so it seems to be a bug in the P2 UI that it is not shown if grouping is disabled:

[merks]

so it seems to be a bug in the P2 UI that it is not shown if grouping is disabled:

I expect it's a design feature not to list EVERYTHING.

[laeubi]

so it seems to be a bug in the P2 UI that it is not shown if grouping is disabled:

I expect it's a design feature not to list EVERYTHING.

From a users perspective its a strange design... grouping of items should not make a difference. And especially if I choose to NOT group things I expect to see everything (if not even more) that I would see if grouping is not used.

I created

• Grouping Items in the Install dialog gives different results than without grouping eclipse-equinox/p2#990