Skip to content

Comments

Query max pages#675

Merged
feruzm merged 3 commits intodevelopfrom
rev
Feb 23, 2026
Merged

Query max pages#675
feruzm merged 3 commits intodevelopfrom
rev

Conversation

@feruzm
Copy link
Member

@feruzm feruzm commented Feb 23, 2026

Summary by CodeRabbit

  • Bug Fixes
    • Removed hard pagination caps across feeds, search, notifications, transactions, and other infinite-scrolling lists so users can load more pages until no further data is available.
  • Style
    • Adjusted vote dialog controls to use the default cursor for a more consistent pointer behavior.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 23, 2026

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d696de5 and 9ff0562.

📒 Files selected for processing (5)
  • apps/web/src/features/shared/entry-vote-btn/entry-vote-dialog.tsx
  • packages/sdk/CHANGELOG.md
  • packages/sdk/package.json
  • packages/wallets/CHANGELOG.md
  • packages/wallets/package.json

📝 Walkthrough

Walkthrough

Removed hard maxPages caps from numerous infinite-query option configurations across the SDK and web app so pagination relies on existing next-page logic and API responses rather than fixed page limits.

Changes

Cohort / File(s) Summary
Posts module
packages/sdk/src/modules/posts/queries/get-account-posts-query-options.ts, packages/sdk/src/modules/posts/queries/get-drafts-query-options.ts, packages/sdk/src/modules/posts/queries/get-fragments-query-options.ts, packages/sdk/src/modules/posts/queries/get-images-query-options.ts, packages/sdk/src/modules/posts/queries/get-posts-ranked-query-options.ts, packages/sdk/src/modules/posts/queries/get-schedules-query-options.ts, packages/sdk/src/modules/posts/queries/get-trending-tags-query-options.ts, packages/sdk/src/modules/posts/queries/get-trending-tags-with-stats-query-options.ts, packages/sdk/src/modules/posts/queries/get-waves-by-host-query-options.ts
Removed maxPages: 5 (or similar) from infiniteQueryOptions; pagination now governed by getNextPageParam/has_next.
Accounts module
packages/sdk/src/modules/accounts/queries/get-account-vote-history-infinite-query-options.ts, packages/sdk/src/modules/accounts/queries/get-friends-infinite-query-options.ts, packages/sdk/src/modules/accounts/queries/get-referrals-infinite-query-options.ts, packages/sdk/src/modules/accounts/queries/get-transactions-infinite-query-options.ts
Removed maxPages caps from infiniteQueryOptions; no other logic changes.
Communities & Notifications
packages/sdk/src/modules/communities/queries/get-account-notifications-infinite-query-options.ts, packages/sdk/src/modules/notifications/queries/get-notifications-infinite-query-options.ts
Dropped maxPages: 5 from infiniteQueryOptions so fetching continues until API indicates end.
Wallet module
packages/sdk/src/modules/wallet/queries/get-hive-asset-metric-query-options.ts, packages/sdk/src/modules/wallet/queries/get-hive-asset-transactions-query-options.ts, packages/sdk/src/modules/wallet/queries/get-hive-power-asset-transactions-query-options.ts, packages/sdk/src/modules/wallet/queries/get-outgoing-rc-delegations-infinite-query-options.ts
Removed maxPages caps from infiniteQueryOptions; getNextPageParam and transforms unchanged.
Hive Engine & Search
packages/sdk/src/modules/hive-engine/queries/get-hive-engine-token-transactions-query-options.ts, packages/sdk/src/modules/search/queries/get-search-api-infinite-query-options.ts
Eliminated maxPages option; pagination now driven solely by next-page logic and API responses.
Web app feed
apps/web/src/api/queries/get-account-posts-feed-query.ts
Removed maxPages: 2 from promoted-entries infinite query configuration.
Misc: UI & packaging
apps/web/src/features/shared/entry-vote-btn/entry-vote-dialog.tsx, packages/sdk/CHANGELOG.md, packages/sdk/package.json, packages/wallets/CHANGELOG.md, packages/wallets/package.json
Added cursor CSS modifier on vote dialog buttons; bumped SDK/wallets package versions and changelogs updated.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Poem

🐰 I nibbled through the page-bound fence,
Caps removed — I hop with no pretense.
From two to endless fields I roam,
A scroll, a hop, the feed's my home.
✨🥕

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Query max pages' accurately summarizes the main change: removing maxPages options from 22 infinite query configurations across the codebase.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch rev

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@feruzm feruzm added the patch Bug fixes and patches (1.0.0 → 1.0.1), add this only if any packages/ have patch changes in PR label Feb 23, 2026
@feruzm feruzm merged commit 9451255 into develop Feb 23, 2026
1 check was pending
@feruzm feruzm deleted the rev branch February 23, 2026 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

patch Bug fixes and patches (1.0.0 → 1.0.1), add this only if any packages/ have patch changes in PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant