Skip to content

Fix build treeshaking#9734

Open
manuelmeister wants to merge 3 commits into
ecamp:develfrom
manuelmeister:fix/build-treeshaking
Open

Fix build treeshaking#9734
manuelmeister wants to merge 3 commits into
ecamp:develfrom
manuelmeister:fix/build-treeshaking

Conversation

@manuelmeister
Copy link
Copy Markdown
Member

Replaced lodash with lodash-es and changed all lodash imports to be named imports.

Visualization:
before.html
after.html

Comment thread frontend/src/App.vue
}

@media #{map-get(settings.$display-breakpoints, 'sm-and-down')} {
@media #{map.get(settings.$display-breakpoints, 'sm-and-down')} {
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple fix, always complains in build

Comment on lines +25 to +34
Vue.component(
'ERichtext',
defineAsyncComponent(() => import('@/components/form/base/ERichtext.vue'))
)
Vue.component('ESelect', ESelect)
Vue.component('ESwitch', ESwitch)
Vue.component('ETextarea', ETextarea)
Vue.component(
'ETextarea',
defineAsyncComponent(() => import('@/components/form/base/ETextarea.vue'))
)
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make tiptap components load async

</template>
<script>
import { keyBy, sortBy } from 'lodash'
import { keyBy, sortBy } from 'lodash-es'
Copy link
Copy Markdown
Member Author

@manuelmeister manuelmeister May 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This blew up the content nodes chunk.

@manuelmeister manuelmeister requested a review from a team May 11, 2026 13:29
@manuelmeister manuelmeister added the deploy! Creates a feature branch deployment for this PR label May 11, 2026
@manuelmeister manuelmeister deployed to feature-branch May 11, 2026 14:23 — with GitHub Actions Active
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 11, 2026

Feature branch deployment ready!

Name Link
😎 Deployment https://pr9734.ecamp3.ch/
🔑 Login test@example.com / test
🕒 Last deployed at Mon May 11 2026 16:26:49 GMT+0200
🔨 Latest commit 305f67b3f5c5ca1d00ab0c52b646b9243bc40a36
🔍 Latest deploy log https://github.com/ecamp/ecamp3/actions/runs/25675958895/job/75374282162
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

deploy! Creates a feature branch deployment for this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant