fix(allpages): make topic-group article cards fully clickable#1849
Closed
silvanus930 wants to merge 1 commit into
Closed
fix(allpages): make topic-group article cards fully clickable#1849silvanus930 wants to merge 1 commit into
silvanus930 wants to merge 1 commit into
Conversation
Topic-group cards only linked the title text while the summary sat outside the anchor, so most of each card was not navigable. Use the same article-card link pattern as the featured directory so the full card is clickable. Co-authored-by: Cursor <cursoragent@cursor.com>
|
Verdict: Close PR #1849: fix(allpages): make topic-group article cards fully clickable This PR changes hover-driven on-screen behavior. Code analysis confirms the visible effect only appears during the interaction, so static before/after screenshots cannot demonstrate it (an identical-looking pair is not valid evidence). A short screen recording or GIF is required. Visual PRs need evidence in the PR description so the maintainer can review the change quickly and reliably. A deploy preview link alone is not enough. Required evidence for resubmission:
Changed files:
CI: Checks still pending: build Please open a new focused PR with the required evidence attached. Automated review by Taopedia Site Maintainer. |
4 tasks
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
On
/wiki/special/allpages, topic-group cards (e.g. under Wallets) only linked the title text. Clicking the summary or empty card area did nothing, even though hover styling made the whole card look clickable.This PR uses the same
<a class="article-card">pattern as the featured directory at the top of the page, so the full card is one link.Reproduction steps
Before (broken)
npm installandnpm run dev./wiki/special/allpages.Video (before):
https://github.com/user-attachments/assets/f641eebd-49e2-4ef2-a36b-5336b91b4557
After (fixed)
Video (after):
https://github.com/user-attachments/assets/5a968211-9e42-4ee5-9bc4-0fb03bc8fbef
Changes
<ul>/<li>+ inner title-only<a>with a grid of full<a class="article-card">links.data-article-cardfilter attributes onto the link element (filter script unchanged)..article-cardhover and layout rules as featured cards.Test plan
npm run dev— open/wiki/special/allpages