Skip to content

fix(allpages): make topic-group article cards fully clickable#1849

Closed
silvanus930 wants to merge 1 commit into
e35ventura:testfrom
silvanus930:fix/allpages-article-card-clickable
Closed

fix(allpages): make topic-group article cards fully clickable#1849
silvanus930 wants to merge 1 commit into
e35ventura:testfrom
silvanus930:fix/allpages-article-card-clickable

Conversation

@silvanus930

Copy link
Copy Markdown

Summary

On /wiki/special/allpages, topic-group cards (e.g. under Wallets) only linked the title text. Clicking the summary or empty card area did nothing, even though hover styling made the whole card look clickable.

This PR uses the same <a class="article-card"> pattern as the featured directory at the top of the page, so the full card is one link.

Reproduction steps

Before (broken)

  1. Run npm install and npm run dev.
  2. Open /wiki/special/allpages.
  3. Scroll to a topic group such as Wallets.
  4. Click Address Poisoning Scams title → navigates correctly.
  5. Click the summary text or padding around the title → no navigation.

Video (before):
https://github.com/user-attachments/assets/f641eebd-49e2-4ef2-a36b-5336b91b4557

After (fixed)

  1. Same steps as above on this branch.
  2. Click anywhere on a topic-group card (title, summary, or padding) → navigates to the article.

Video (after):
https://github.com/user-attachments/assets/5a968211-9e42-4ee5-9bc4-0fb03bc8fbef

Changes

  • Replaced <ul>/<li> + inner title-only <a> with a grid of full <a class="article-card"> links.
  • Moved data-article-card filter attributes onto the link element (filter script unchanged).
  • Consolidated CSS so topic-group cards share the same .article-card hover and layout rules as featured cards.

Test plan

  • npm run dev — open /wiki/special/allpages
  • Click title, summary, and card padding on a topic-group card — all navigate
  • Featured cards at top still work
  • Topic filter buttons still hide/show cards correctly
  • Search filter still hides non-matching cards and empty topic sections
  • Responsive layout at ≤780px (single column)

Topic-group cards only linked the title text while the summary sat outside
the anchor, so most of each card was not navigable. Use the same article-card
link pattern as the featured directory so the full card is clickable.

Co-authored-by: Cursor <cursoragent@cursor.com>
@silvanus930 silvanus930 requested a review from e35ventura as a code owner June 28, 2026 13:46
@taopedia-site-maintainer taopedia-site-maintainer Bot added ui-ux Visual design, layout, or usability work other Maintenance, deployment, tooling, validation, or repo work outside preferred categories labels Jun 28, 2026
@taopedia-site-maintainer

Copy link
Copy Markdown

Verdict: Close

PR #1849: fix(allpages): make topic-group article cards fully clickable

This PR changes hover-driven on-screen behavior. Code analysis confirms the visible effect only appears during the interaction, so static before/after screenshots cannot demonstrate it (an identical-looking pair is not valid evidence). A short screen recording or GIF is required.

Visual PRs need evidence in the PR description so the maintainer can review the change quickly and reliably. A deploy preview link alone is not enough.

Required evidence for resubmission:

  • Page URL.
  • Viewport width, especially for responsive changes.
  • Action taken (the hover that reveals the change).
  • Expected before behavior.
  • Expected after behavior.
  • A short video/GIF that shows the change happening during the interaction. Static screenshots alone are not accepted for this PR.

Changed files:

  • src/pages/wiki/special/allpages.astro

CI: Checks still pending: build

Please open a new focused PR with the required evidence attached.


Automated review by Taopedia Site Maintainer.

@silvanus930 silvanus930 deleted the fix/allpages-article-card-clickable branch June 28, 2026 13:54
@silvanus930 silvanus930 restored the fix/allpages-article-card-clickable branch June 28, 2026 13:54
@silvanus930 silvanus930 deleted the fix/allpages-article-card-clickable branch June 28, 2026 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

other Maintenance, deployment, tooling, validation, or repo work outside preferred categories ui-ux Visual design, layout, or usability work

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant