fix: remove mount animation from projects announcement banner - #517
fix: remove mount animation from projects announcement banner#517devin-ai-integration[bot] wants to merge 1 commit into
Conversation
Co-Authored-By: ben@e2b.dev <ben@e2b.dev>
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
LGTM — trivial removal of a mount animation and its unused keyframe/variable definitions.
Extended reasoning...
Overview
This PR removes the animate-announcement-in motion-reduce:animate-none class from the projects announcement banner container (banner.tsx) and deletes the now-unused @keyframes announcement-in and --animate-announcement-in theme variable from theme.css. No logic, state, or props are touched — the component's mount/dismiss/localStorage behavior is unchanged, only a purely presentational CSS animation is removed.
Security risks
None. This touches only static CSS class names and a Tailwind theme keyframe definition. No user input, auth, or data handling is involved.
Level of scrutiny
Low. This is a cosmetic, single-purpose UI tweak confined to one non-critical banner component and a shared theme file. I confirmed via grep that announcement-in/--animate-announcement-in are not referenced anywhere else in the codebase, so removing them does not orphan any other usage.
Other factors
The diff is minimal and mechanical (class removal + dead CSS deletion), matches the PR description exactly, and there are no outstanding review comments to address.
|
closed because it's better to have the animation in the end. |
Summary
The "Teams are being renamed to projects" banner animated in on mount. This removes that animation so the banner appears instantly.
animate-announcement-in motion-reduce:animate-nonefrom the banner container inbanner.tsx.@keyframes announcement-inand--animate-announcement-infromtheme.css.Link to Devin session: https://app.devin.ai/sessions/9848acc809e247a5babe9185626b98ee
Need help on this PR? Tag
/codesmithwith what you need. Autofix is disabled.