Skip to content

Conversation

@joshkel
Copy link
Contributor

@joshkel joshkel commented Jul 31, 2025

Specific changes:

  • Clean up ESLint configurations: ESLint checks eslint.config.js before checking eslint.config.mjs, so eslint.config.mjs had no effect. Calling ESLint's configuration file .mjs ensures that it's always recognized as ESM, regardless of package.json.
  • Delete old .eslintrc. It has no effect in ESLint 9.
  • Delete "type": "module". As I understand it, hapi-auth-jwt2 itself is still CommonJS. "type": "module" was added to make ESLint 9.x configurations happier, but preceding commits should address that.
  • Add "Are the Types Wrong" to help catch future issues with TypeScript types, such as the one fixed here.

Fixes #511

joshkel added 4 commits July 31, 2025 16:40
ESLint checks `eslint.config.js` before checking `eslint.config.mjs`, so `eslint.config.mjs` had no effect.

Calling ESLint's configuration file `.mjs` ensures that it's always recognized as ESM, regardless of package.json.
It has no effect in ESLint 9.
As I understand it, hapi-auth-jwt2 itself is still CommonJS. `"type": "module"` was added to make ESLint 9.x configurations happier, but preceding commits should address that.
… types

Such as the one fixed in the previous commit.
@codecov
Copy link

codecov bot commented Jul 31, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (0855867) to head (488f78b).
⚠️ Report is 32 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #545   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines          155       155           
  Branches        45        45           
=========================================
  Hits           155       155           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug in v11.0.0

1 participant