Skip to content

Peer Review by Shijing #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
shijing-z wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Peer Review by Shijing #6

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion content/post/2021-04-16-functional-programming-with-strava-data/index.Rmd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ tidyfunc <- strav_data %>%
# removes activities with no duration (which rules out manually entered activities where no time is supplied) and also incorrect calculations where Strava defines the an average speed that is higher than the max speed (this most often occurs in swimming)



## Comment by Shijing: I like how you added comment to explain what your code is doing. This is really helpful for people to learn.
```

After our data has a first-pass-tidy, we want to sort out which activities occurred frequently enough that they would be useful to display visually. In our view, having 98% of your activities comprise three different types (e.g., hiking, running, and biking), and 2% of your activities comprise 4 types (e.g., stand-up paddle boarding, walking, rock climbing, and jump rope), then your visualization will be skewed. It is certainly possible to select specific activities to visualize, and this will be something you can read more about later. For now, we're going to pair down our data to activity types that occur most commonly.
Expand Down
3 changes: 3 additions & 0 deletions content/post/2021-04-16-functional-programming-with-strava-data/paralleliterations.Rmd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,3 +94,6 @@ walk2(paths, final_plots$eugeneroads, ggsave,

````

### Overall comment by Shijing:

I think how you incorporate comment as explanation for your code is really friendly for viewers, especially for those who are less confident with coding. The language use for the blog (in `jd_post.Rmd`) is intriguing to read. The steps are broken down nicely, and linking blog posts together for your blog is a good idea for viewers to navigate. One potential improvement in the future could be displaying and explaining outputs briefly (or at least a part of a output by using `head()`) to complement your explanation of code so that people know what to expect if they want to adapt your code. I never use `walk2()` before, which is something new I learned!