Keep the metacoder taxonomy graph as one tree - #9
Merged
Merged
Conversation
Empty ranks were parsed as nodes named NA, and genus/species labels without a shared kingdom became a forest. Drop those nodes and reattach their children the way parse_phyloseq does, and add a root only when the remaining ranks do not already share one parent. Co-authored-by: dvsmutin <dvsmutin@gmail.com>
dsmutin
marked this pull request as ready for review
September 25, 2026 09:58
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
engine = "metacoder"differential trees were a forest: missing ranks became nodes namedNA, and genus/species parsed from labels had one root per genus.metacoder::parse_phyloseqfilters taxa named"NA". Arootnode is added only when the remaining ranks do not already share one parent.phyloseq_to_metacoder()uses that construction forarchi_phyloseqlists, andparse_phyloseqfor a real phyloseq object when that result is already one tree.Verification
Bacteria), no nodes namedNA, and every other node has exactly one parentroot