Fix the case of lazy loading ttvc#92
Merged
ajhyndman merged 1 commit intodropbox:mainfrom Jan 21, 2026
Merged
Conversation
|
|
Contributor
Author
|
@ajhyndman I finally figured out the bureaucracy with the signing - so I am contributing this back from the work account. Snowflake should have signed the company level CLA as well. I will close #91 from home (or feel free to close it yourself) |
ajhyndman
approved these changes
Jan 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses the issue where ttvc is loaded into an SPA after the window.load has fired.
In the current state that means the observer for the resources never registers.
This is already properly handled in the waitForPageLoad called from visuallyCompleteCalculator, we check the document.readyState and immediately resolve if it is complete. But it was not handled for the networkIdleObservable.
I have added the test that validates this behavior. Without the fix it marks ttvc before the img is ever downloaded.
Obviously there is still a gap if the resource started downloading before ttvc was initialized, but at least this way ttvc will work for future SPA navigations. Without this fix any future resources (e.g. additional bundles) are also not tracked.