Make cp command for a single source avoid preserving the original folder structure#172
Open
lorisp1 wants to merge 1 commit intodropbox:masterfrom
Open
Make cp command for a single source avoid preserving the original folder structure#172lorisp1 wants to merge 1 commit intodropbox:masterfrom
lorisp1 wants to merge 1 commit intodropbox:masterfrom
Conversation
…rving the original structure
|
Loris Pozzobon seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using
cpcommand I noticed the following behaviour. Let's suppose I have File-A.txt within the following structure:while the following folder is empty:
Now I copy File-A.txt to
dbxcli/folderB/folder1/File-A.txt:As a normal
cpcommand, I'd expect to find the file indbxcli/folderB/folder1/File-A.txt. Instead, File-A.txt is a folder that contains the whole original folder structure:I can see the reason why it is important to preserve the original structure when you specify more than one source (i.e. avoiding name conflicts on the destination), but when there is a classic
cp <from> <to>structure, I think it would be more useful to use the specified destination as the actual destination where the file/folder will be placed. Otherwise you would not be able to copy a single file from A to B.The purpose of this merge request is changing
cpcommand so that it preserves the original folder structure if and only if more than one source has been specified. Otherwise, it will work as a classiccp, having one source and one actual destination.Starting from the same preconditions as the previous example, now
cpwould work as follows: