feat: isolate populate_obj in a separate method so that it can be easily overriden#2260
Open
eqperes wants to merge 2 commits intodpgaspar:masterfrom
Open
feat: isolate populate_obj in a separate method so that it can be easily overriden#2260eqperes wants to merge 2 commits intodpgaspar:masterfrom
eqperes wants to merge 2 commits intodpgaspar:masterfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2260 +/- ##
==========================================
+ Coverage 73.81% 74.65% +0.84%
==========================================
Files 72 72
Lines 8754 9041 +287
==========================================
+ Hits 6462 6750 +288
+ Misses 2292 2291 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
eqperes
force-pushed
the
populate-item-separate-method
branch
from
04d62a5 to
83c8aff
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Similar to update_model on Flask-Admin, isolating the call to
form.update_objto a separate method allows the step to be easily overridden. Currently, the methods exposed can access either the form (process_form, for example) or the item (pre_add,pre_update, for example), but not both. Depending on the behavior to be implemented, access to both can be really useful.ADDITIONAL INFORMATION