Repository navigation
fix(frontend): add the missing /api/ link to the wasm demo page - #47
Merged
Merged
Conversation
Found live by the user comparing against RustyNES's own Pages deployment (which has an <a href="api/">API documentation</a> footer link) -- RustySNES's demo page had no path to the API docs short of manually typing /api/ into the URL bar. Adds a small footer mirroring RustyNES's own pattern. Verified locally: RUSTFLAGS="-C target-feature=-reference-types" trunk build --release --public-url /RustySNES/ produces the footer correctly in dist/index.html. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
There was a problem hiding this comment.
Code Review
This pull request adds a footer to the WebAssembly demo page with links to the GitHub repository and the API documentation, along with corresponding CSS layout adjustments and a changelog entry. The reviewer suggests opening these links in a new tab using target="_blank" to prevent users from losing their active emulation state when navigating away.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
Gemini review finding on PR #47: navigating away from the page in the same tab kills the running wasm instance and any in-progress emulation state. Adds target="_blank" rel="noopener noreferrer" to both footer links. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
…i-link # Conflicts: # CHANGELOG.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
<a href="api/">API documentation</a>in a small footer; RustySNES's had nothing (you'd have to manually type/api/into the URL bar).<p class="hint">) with a GitHub repo link + an API docs link, styled to match the existing dark theme.RUSTFLAGS="-C target-feature=-reference-types" trunk build --release --public-url /RustySNES/produces the footer correctly indist/index.html.Separately investigated, not part of this PR: the user also reported the demo canvas itself renders blank. Root-caused via a headless-Chromium (Playwright) load with full console/network capture: the wasm module loads and initializes without any errors (
window.wasmBindingspopulates correctly), butcrates/rustysnes-frontend/src/wasm.rsis — and has always been — an explicitly-labeled scaffold stub ("v0.1.0: a minimal bootstrap... The full browser frontend... is a TODO for the implementation phase"). It installs a panic hook and logs one console message, then returns — it never builds theApp, creates a wgpu surface from a<canvas>, or drives arequestAnimationFrameloop. This isn't a regression from this session's PRs; it predates all of them. Every "wasm demo is live" verification this project has done so far (v0.1.0onward) checked HTTP-level liveness (200 status, correct content-types) — not that the app actually renders. RustyNES's own wasm frontend spans 13 files (wasm.rs,wasm_winit.rs,wasm_audio.rs,wasm_gamepad.rs,wasm_io.rs,wasm_idb.rs,wasm_save_states.rs,wasm_touch.rs,wasm_lobby.rs,wasm_script.rs,wasm_cheevos.rs,wasm_netplay.rs,wasm_share.rs) for comparison — building RustySNES's out to real parity is genuinely substantial work, not a quick fix, and is being raised separately for scoping/sequencing against thev0.8.0+ ladder rather than folded into this small PR.Test plan
trunk build --releasesucceeds, footer present in output🤖 Generated with Claude Code