Skip to content

Add filters to findmany courses route#2956

Draft
henrygraesberg wants to merge 6 commits intomainfrom
grd-24-add-filters-to-findmany-courses-route
Draft

Add filters to findmany courses route#2956
henrygraesberg wants to merge 6 commits intomainfrom
grd-24-add-filters-to-findmany-courses-route

Conversation

@henrygraesberg
Copy link
Member

No description provided.

@linear
Copy link

linear bot commented Feb 25, 2026

Comment on lines +17 to +19
sortByAverageGrade: z.boolean(),
sortByPassRate: z.boolean(),
sortByStudentCount: z.boolean(),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should probably use an optional anyOfFilter instead

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rename file to course-types.ts

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably move this to packages/utils or something like that

Comment on lines +17 to +19
sortByAverageGrade: z.boolean(),
sortByPassRate: z.boolean(),
sortByStudentCount: z.boolean(),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed

Copy link
Member

@brage-andreas brage-andreas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants