Chore/1445 node version pinning#1495
Closed
Oluwasuyi-Timilehin wants to merge 1 commit into
Closed
Conversation
|
@Oluwasuyi-Timilehin Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Owner
|
fix conflicts. |
Author
|
@dotandev I already fixed conflicts. |
31997cc to
0eafa35
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#closes #1445
Title
Description
Adds the
enginesfield to package.json to enforce Node.js version >= 18.0.0 for the protocol handler and audit scripts. This ensures the project runs on a supported Node.js version and provides clear version requirements to users and CI/CD systems.Related Issues
Closes #1445
Motivation
The package.json file lacked an
enginesfield, which meant there was no explicit version requirement for Node.js. This could lead to:By adding the
enginesfield, we:Changes Made
package.jsonto add theenginesfield"node": ">= 18.0.0"as the version requirementTesting
Verification Steps
Verify the package.json change
Expected output:
Validate JSON syntax
node -e "console.log(JSON.stringify(require('./package.json'), null, 2))"Expected: No syntax errors, valid JSON output
Check current Node.js version
Expected: Should show version >= 18.0.0 (e.g., v18.x.x, v20.x.x, etc.)
Verify npm recognizes the engines field
npm view . enginesExpected: Should display
{ node: '>= 18.0.0' }Test with npm
Expected: If Node version meets requirement, installation proceeds normally. If Node version is below 18.0.0, npm will show a warning.
Verify the change matches the issue requirement
enginesfield is present in package.json>= 18.0.0Expected Behavior
Checklist
Impact Assessment
Benefits
Compatibility
Version Rationale
Additional Notes
enginesfield is a standard package.json field supported by npm and yarn#closes