Chore/1444 enable race detector make test#1494
Open
Oluwasuyi-Timilehin wants to merge 1 commit into
Open
Conversation
|
@Oluwasuyi-Timilehin Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Owner
|
Fix conflicts and CI |
Author
|
@dotandev I already fixed conflict and CI |
37a4725 to
374c320
Compare
Author
|
Hey @dotandev , I've completely cleaned up the git history for this branch so the diff is now clean and only contains the intended changes without any of the conflict artifacts. Could you please approve the workflows to run? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#closes #1444
Title
Description
Adds the
-raceflag to the defaultmake testtarget in the Makefile to enable Go's race detector during local development. This ensures developers can catch concurrency bugs locally before they reach CI, improving code quality and reducing feedback loops.Related Issues
Closes #1444
Motivation
The default
make testtarget was runninggo test ./...without the-raceflag, meaning race detection only occurred in CI. This created a gap where developers could push code with race conditions that would only be caught after submission. By adding-raceto the default test target, race detection runs locally during development, allowing developers to identify and fix concurrency issues before pushing.Changes Made
Makefileline 25go test ./...togo test -race ./...Testing
Verification Steps
Verify the Makefile change
Expected output:
Run the test target to confirm race detection is enabled
make testVerify race detector is active
WARNING: DATA RACEmessages if there are race conditions-raceflag should be visible in the test command outputTest with a specific package to confirm flag is being used
go test -race ./...This should produce the same behavior as
make testRun linting to ensure code quality
Expected Behavior
Checklist
Impact Assessment
Benefits
Performance Considerations
go test ./...without-raceif needed for faster iterationCompatibility
make testtargetgo test ./...directlyAdditional Notes
#closes