Skip to content

chore/add-rustfmt-toml#1467

Open
SamixYasuke wants to merge 4 commits into
dotandev:mainfrom
SamixYasuke:chore/add-rustfmt-toml
Open

chore/add-rustfmt-toml#1467
SamixYasuke wants to merge 4 commits into
dotandev:mainfrom
SamixYasuke:chore/add-rustfmt-toml

Conversation

@SamixYasuke

Copy link
Copy Markdown

PULL REQUEST TEMPLATE

================================================================================
TITLE: Add missing rustfmt.toml

feat(audit): Add AWS KMS Direct Support for Signing - Issue #393
chore: Add rustfmt toml - Closes #1436

================================================================================
DESCRIPTION: Added rustfmt.toml with consistent Rust formatting settings.

================================================================================

@drips-wave

drips-wave Bot commented Jun 1, 2026

Copy link
Copy Markdown

@SamixYasuke Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@SamixYasuke

Copy link
Copy Markdown
Author

@dotandev Please review

@dotandev dotandev left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks.

@SamixYasuke

Copy link
Copy Markdown
Author

@dotandev Please merge

@dotandev

dotandev commented Jun 2, 2026

Copy link
Copy Markdown
Owner

fix the CI, please.

@SamixYasuke

Copy link
Copy Markdown
Author

@dotandev done

@dotandev

dotandev commented Jun 2, 2026

Copy link
Copy Markdown
Owner

you made changes to 29 files, mostly irrelevant to the issue.

can you please look into that?

@SamixYasuke

SamixYasuke commented Jun 2, 2026

Copy link
Copy Markdown
Author

you made changes to 29 files, mostly irrelevant to the issue.

can you please look into that?

Yes I made changes to those files to fix the ci issues, I also resolved a merge conflict, so cargo format all ran across those files

@SamixYasuke

Copy link
Copy Markdown
Author

@dotandev have you reviewed the ci fix changes made?

@SamixYasuke

Copy link
Copy Markdown
Author

@dotandev I'm still awaiting a reply

@dotandev

Copy link
Copy Markdown
Owner

@dotandev I'm still awaiting a reply

hey, I am not going to merge this PR now because the file changes are not consistent.

however, I'd acknowledge your effort as the drips team has advised.

@SamixYasuke

Copy link
Copy Markdown
Author

@dotandev I'm still awaiting a reply

hey, I am not going to merge this PR now because the file changes are not consistent.

however, I'd acknowledge your effort as the drips team has advised.

@dotandev Please review the changes in the 29 files manually. Most of those modifications were made automatically by the formatter and are formatting-related rather than functional changes. The actual code changes are limited to the files relevant to the feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add missing rustfmt.toml

2 participants