fix(#1409): Replace unsafe unwrap with safe error handling in HSM module#1449
Open
amankoli09 wants to merge 2 commits into
Open
fix(#1409): Replace unsafe unwrap with safe error handling in HSM module#1449amankoli09 wants to merge 2 commits into
amankoli09 wants to merge 2 commits into
Conversation
- Replace .unwrap() with .expect() in test with descriptive error message - Replace .unwrap_or_default() with .unwrap_or_else() for clarity - Ensures configuration errors bubble up to Go CLI for proper user reporting - Fixes issue dotandev#1409: Avoid unwrap in HSM module root
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Tweaks configuration handling and test diagnostics for the HSM signer factory.
Changes:
- Adjusted mock HSM config fallback to use an explicit
MockHsmConfig::default()closure. - Improved test failure output by replacing
unwrap()withexpect(...).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| } | ||
| "mock" => { | ||
| let mock_config = config.mock.clone().unwrap_or_default(); | ||
| let mock_config = config.mock.clone().unwrap_or_else(|| MockHsmConfig::default()); |
Author
|
@dotandev please give me points on the drip |
Owner
|
the CI is failing, you ought to fix it, when you do, the points would be auto-assigned to you by drips themselves. |
The unwrap_or_else(|| MockHsmConfig::default()) pattern triggers clippy's redundant_closure error. Replace with the idiomatic unwrap_or_default() which satisfies strict CI linting (-D clippy::all).
Author
|
@dotandev approval is required from your side please approve it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1409
Description
Remove unwrap calls from HSM module root to allow proper error
handling and reporting in the Go CLI.
Changes
.unwrap()with.expect()in test with descriptive error message.unwrap_or_default()with.unwrap_or_else()for explicit clarityTesting
Benefits