Feature/1373 optimize memory limit enforcement#1376
Open
emickwrld wants to merge 2 commits into
Open
Conversation
added 2 commits
May 29, 2026 14:07
Fixes dotandev#1365 Switch from base64.StdEncoding.DecodeString to base64.StdEncoding.Strict().DecodeString to catch slightly malformed or padded XDR strings immediately.
- Enable testutils feature for soroban-env-host to access reset_limits() API - Hook memory_limit parameter into Budget tracking mechanism via reset_limits() - Memory overruns now result in clean BudgetExceeded errors during execution - Update SimHost::new() and SimHost::from_snapshot() to enforce memory limits - Preserve CPU limits while setting custom memory limits
Author
|
Closes #1373 |
Owner
|
fix ci, please. |
|
@emickwrld Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Owner
Owner
|
hey, please fix the ci errors if you're still interested in this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PULL REQUEST TEMPLATE
================================================================================
TITLE:
feat(audit): Add AWS KMS Direct Support for Signing - Issue #393
================================================================================
DESCRIPTION:
Overview
Implements native AWS KMS direct support for audit trail signing, replacing pure PKCS#11 mapping with direct KMS API integration.
Changes
Core Implementation
KmsEd25519Signer: New plugin class implementing
AuditSignerinterfaceFactory Integration: Extended
createAuditSigner()to support 'kms' providerDependencies: Added
@aws-sdk/client-kmsv3.609.0Testing
Documentation
Security Properties
Configuration
Required environment variables:
ERST_KMS_KEY_ID: KMS key ARN or IDERST_KMS_PUBLIC_KEY_PEM: Ed25519 public key in PEM formatERST_KMS_REGION: AWS region (optional, defaults to us-east-1)IAM Permissions
Minimal policy required:
{ "Effect": "Allow", "Action": ["kms:Sign"], "Resource": "arn:aws:kms:*:ACCOUNT-ID:key/KEY-ID", "Condition": { "StringEquals": { "kms:SigningAlgorithm": "Ed25519" } } }Verification
Related Issues
Closes #1373
Type of Change
Checklist
================================================================================