Skip to content

Update sale-response.kts#71

Open
BenRichardson-bit wants to merge 1 commit into
mainfrom
BenRichardson-bit-patch-3
Open

Update sale-response.kts#71
BenRichardson-bit wants to merge 1 commit into
mainfrom
BenRichardson-bit-patch-3

Conversation

@BenRichardson-bit
Copy link
Copy Markdown
Contributor

Added date time in line with recent updates

Added date time in line with recent updates
@BenRichardson-bit BenRichardson-bit requested a review from a team as a code owner March 13, 2026 10:00
@gemini-code-assist
Copy link
Copy Markdown

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the sale-response.kts script to include the transaction date and time. This enhancement ensures that the mock sale response accurately reflects recent API changes by providing a DATE_TIME extra in ISO 8601 UTC format, which is crucial for applications relying on precise transaction timestamps.

Highlights

  • Transaction Date/Time: Added the "com.dojo.extra.DATE_TIME" extra to the sale response intent, providing the transaction's date and time in ISO 8601 UTC format.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • mobile-sdk/android/tap-to-pay/kotlin/sale-response.kts
    • Added the "com.dojo.extra.DATE_TIME" extra to the intent.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a DATE_TIME extra to the sale response intent. The implementation uses a hardcoded future date. My review includes a suggestion to dynamically generate the current timestamp instead, which is a better practice even for example code, as it prevents the value from becoming stale and demonstrates the correct implementation.

intent.putExtra("com.dojo.extra.CARD_APPLICATION_LABEL", "VISA DEBIT")
intent.putExtra("com.dojo.extra.CARD_APPLICATION_ID", "A0000000031010")
intent.putExtra("com.dojo.extra.CARD_PAN", "************0226") // masked PAN
intent.putExtra("com.dojo.extra.DATE_TIME", "2026-02-13T10:23:45.123456Z") // Time date for the transaction, ISO 8601 UTC e.g. "2026-02-13T10:23:45.123456Z"
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The date and time for the transaction is hardcoded to a future date. While this is an example file, using a hardcoded value can be misleading and become stale. It's better practice to dynamically generate the current timestamp. This makes the example more robust and demonstrates the correct way to generate this value.

intent.putExtra("com.dojo.extra.DATE_TIME", java.time.Instant.now().toString()) // Time date for the transaction, ISO 8601 UTC e.g. "2026-02-13T10:23:45.123456Z"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant