Skip to content

Fix Channel Check grouping bugs#372

Open
danielskeenan wants to merge 5 commits intodocsteer:masterfrom
danielskeenan:362-chan-check-blink-grouping
Open

Fix Channel Check grouping bugs#372
danielskeenan wants to merge 5 commits intodocsteer:masterfrom
danielskeenan:362-chan-check-blink-grouping

Conversation

@danielskeenan
Copy link
Copy Markdown
Contributor

Fixes #362
Fixes #364
Fixes #365

These are all related issues that are solved similarly. Moves the output buffer updating logic out of the number changed slot and into its own function. Then call that function when related components change.

Copy link
Copy Markdown
Collaborator

@RichardTea RichardTea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants