-
Notifications
You must be signed in to change notification settings - Fork 29
use bake matrix strategy #210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
56f28f3 to
0dc74e0
Compare
Signed-off-by: CrazyMax <[email protected]>
vvoland
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM overall
| distro: distro, | ||
| platform: platform | ||
| platform: platform, | ||
| verify: platform.startsWith('linux/386') || platform.startsWith('linux/amd64') || platform.startsWith('linux/arm64') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not verify all linux/?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would segfault through emulation atm, I can add a TODO comment.
Signed-off-by: CrazyMax <[email protected]>
Signed-off-by: CrazyMax <[email protected]>
|
Debian repos not happy https://github.com/docker/packaging/actions/runs/15607567172/job/43960593852?pr=210#step:7:2061 We might need some retry logic in such case |
Signed-off-by: CrazyMax <[email protected]>
Signed-off-by: CrazyMax <[email protected]>
CosmicJesterX
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tried this?
fixes #209
fixes #200
fixes #83
Huge refactor by using Bake matrix strategy to reduce quite a lot code duplication. Everything has been moved to the Bake definition at root level. Same for Makefiles that have been removed as well as the helpers. Just the main Makefile is kept but not necessary. You just need Bake.
Following these changes, the ci workflows have changed. We now have two levels for distributing the workload. One job for each distro (as before) and also one for each platform. I also took the opportunity to runs builds on best-matching runner. This is now way faster and builds every distros and supported platforms for each package (even on PR) to make sure there is no regression. Before we would need to have minimal list of distros and platforms to build to reduce build time (almost 1h).
I didn't touch yet the release workflow but will do as follow-up. This PR is already huge.
follow-ups:
./pkg/*/scriptsscriptsADDto clone pkg to have material part of the provenance