build/bake: allow runner mappings for platform-specific builds#188
Open
crazy-max wants to merge 5 commits intodocker:mainfrom
Open
build/bake: allow runner mappings for platform-specific builds#188crazy-max wants to merge 5 commits intodocker:mainfrom
crazy-max wants to merge 5 commits intodocker:mainfrom
Conversation
tonistiigi
reviewed
May 6, 2026
| with: | ||
| script: | | ||
| const runnerEnvironment = core.getInput('runner-environment'); | ||
| if (runnerEnvironment !== 'github-hosted') { |
Member
There was a problem hiding this comment.
Should this also check "linux"?
Member
Author
There was a problem hiding this comment.
Yes, good catch. Updated this to require both runner.environment == 'github-hosted' and runner.os == 'Linux'.
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #161
This change lets the
runnerinput accept either a single GitHub-hosted Linux runner label or newline-delimited mappings that select runner labels by platform prefix.The build and bake workflows now parse runner mappings, resolve the most specific matching platform prefix for distributed builds, keep
ubuntu-24.04as the default runner, and route Linux ARM platforms toubuntu-24.04-arm.The previous
auto,amd64, andarm64values are still supported for compatibility, but they now emit deprecation warnings. Existing callers keep working, while new configurations can use explicit runner labels or platform mappings instead.This keeps the current GitHub-hosted Linux runner contract and makes runner selection more explicit and extensible without introducing a generic
runs-onescape hatch.