Add support for ScitagConfig tweak in SetupCMSSWPset for CMSSW >= 16_0_0

[hassan11196]

Related to cms-sw/cmssw#47517

Status

In development

Description

PSet tweak to add support for "Production Input" case for SciToken packet labelling.
cms-sw/cmssw#47517 (comment)

Is it backward compatible (if not, which system it affects?)

YES

Related PRs

No

External dependencies / deployment changes

CMSSW cms-sw/cmssw#49740

[dmwm-bot]

Jenkins results:

• Python3 Unit tests: succeeded
  • 1 changes in unstable tests
• Python3 Pylint check: failed
  • 10 warnings and errors that must be fixed
  • 4 warnings
  • 72 comments to review
• Pycodestyle check: succeeded
  • 20 comments to review

Details at https://cmssdt.cern.ch/dmwm-jenkins/view/All/job/WMCore-PR-Report/1142/artifact/artifacts/PullRequestReport.html

[makortel]

Does this apply the part

process.ScitagConfig.productionCase = cms.untracked.bool(True)

also when process.ScitagConfig already exists in the process?

[hassan11196]

Hi @makortel, you are indeed correct. It would have skipped the productionCase assignment if process.ScitagConfig already existed.
I have updated the tweak to always have a seperate "tweak" for productionCase.

[makortel]

Thanks, looks good to me now (as far as I interpret correctly what the code does)

[dmwm-bot]

Jenkins results:

• Python3 Unit tests: succeeded
• Python3 Pylint check: failed
  • 10 warnings and errors that must be fixed
  • 4 warnings
  • 72 comments to review
• Pycodestyle check: succeeded
  • 20 comments to review

Details at https://cmssdt.cern.ch/dmwm-jenkins/view/All/job/WMCore-PR-Report/1143/artifact/artifacts/PullRequestReport.html

[LinaresToine]

Hello @hassan11196 @makortel

Tier-0 recently began using CMSSW_16_0_X and we are seeing this error during the parsing of FrameworkJobReport.xml:

Error reading XML job report file, possibly corrupt XML File:
Details: <@========== WMException Start ==========@>
Exception Class: FwkJobReportException
Message: Error reading XML job report file, possibly corrupt XML File:
Details: not well-formed (invalid token): line 12, column 213
	ClassName : None
	ModuleName : WMCore.FwkJobReport.Report
	MethodName : parse
	ClassInstance : None
	FileName : /srv/job/WMCore.zip/WMCore/FwkJobReport/Report.py
	LineNumber : 157
	ErrorNr : 0

Traceback: 
  File "/srv/job/WMCore.zip/WMCore/FwkJobReport/Report.py", line 145, in parse
    xmlToJobReport(self, xmlfile)

  File "/srv/job/WMCore.zip/WMCore/FwkJobReport/XMLParser.py", line 566, in xmlToJobReport
    node = xmlFileToNode(xmlFile)

  File "/srv/job/WMCore.zip/WMCore/Algorithms/ParseXMLFile.py", line 64, in xmlFileToNode
    expat_parse(open(reportFile, 'rb'),

  File "/srv/job/WMCore.zip/WMCore/Algorithms/ParseXMLFile.py", line 88, in expat_parse
    parser.ParseFile(f)

The line in the xml file that the logs complain about is:

<PFN>root://eoscms.cern.ch//eos/cms/tier0/store/unmerged/express/Tier0_REPLAY_2026/ExpressCosmics/FEVT/Express-v3152115/000/390/094/00000/b4738d4f-e3e7-4ff7-9a22-df9c053fc23f.root?eos.app=cmst0&scitag.flow=196664</PFN>

I believe this is related to this PR, Im I correct?

[hassan11196]

Hi @LinaresToine

The PSet tweak is not yet merged to WMCore, we are still testing it with some Relvals.

From you line I suspect the & between eos.app=cmst0&scitag.flow=196664 is the cause and this comes from CMSSW afaiu.

I think it will be useful to mention this in the CMSSW issue cms-sw/cmssw#47517

Thanks

[LinaresToine]

Thanks for the reply @hassan11196

Are you saying that this patch does not fix the issue? I am currently running the workflows again, this time applying this patch.

Nonetheless, I will report in the cmssw issue as you advice

[makortel]

Yes, we need to replace the & with & to make it valid XML.

[LinaresToine]

Thanks a lot @makortel and @hassan11196