Repository navigation
Conversation
Author
|
Following up on #50: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The accumulator-copy rule now supports
requireArrayReceiver: true, using the existing local array evidence helper before classifying a reduce/ reduceRight callback. A custom one-call API can avoid the growing-array warning, while known array literals, aliases and typed array chains remain covered. The default method-name heuristic stays compatible and is now documented.Fixes #50, using the report's suggested documented heuristic plus an option requiring recognized array evidence.
Validation: the custom-receiver regression fails before the behavior change; seven new regression/control cases and all existing rule suites pass.
pnpm check(lint, full tests, typecheck, synchronized skill asset check) andgit diff --checkpass. Independent review passed. The vendored skill payload was regenerated withpnpm sync:skill-assets.AI-assisted implementation and wording.