Repository navigation
feat: vendor autofixable readable spacing rule - #43
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ship
anti-slop/require-readable-spacingas an opinionated, whitespace-autofixable generic rule. Agents increasingly remove structural blank lines; a formatter preserves that condensed layout rather than restoring readability.padding-line-between-statementsengine and option types from435c3ea0fd26a5fef9042c4b36b6e165fbbf8d08.The vendored engine + helper/type surface is 1,044 lines; the policy wrapper is 47 lines. The duplicate in skill assets is generated distribution, not a second implementation owner.
Verification
pnpm checkpassed: root lint, all RuleTester suites, native CLI integration, typecheck, and skill-asset parity.cf-twitchon Oxlint 1.80.0 passed root enforcement and lint/Oxfmt convergence, strict typechecking, unit tests, and all three local workerd journeys. Upstream checks use the existing pinned Oxlint 1.78.0.git diff --checkpassed.Boundaries
This is structural spacing, not inference of every logical group. It does not add braces, wrap expressions, sort imports, or enable a competing formatter preset. The complete upstream JS/TS test suites are not ported; focused Oxlint compatibility tests and native CLI evidence are included instead. Upstream non-null assumptions remain localized in vendored source; indexed reads have explicit guards for consumers using
noUncheckedIndexedAccess.