Skip to content

Clean up otm_queue - #3

Open
dnadlinger wants to merge 6 commits into
dlang-community:masterfrom
dnadlinger:otm_queue
Open

Clean up otm_queue#3
dnadlinger wants to merge 6 commits into
dlang-community:masterfrom
dnadlinger:otm_queue

Conversation

@dnadlinger

Copy link
Copy Markdown

This removes a few remnants from before OtMQueue was split (which is indeed a good idea), clarifies some comments, and allows non-core.atomic-compatible element types.

I'll probably post another PR that briefly explains the implementation ("phases"/…) tomorrow.

This is a follow-up to the OtMQueue split.
The producer count is only used for debug asserts, so replace it
with a property.
core.atomic operations are @safe now, and we don't want to accidentally
@Trust unsafe assignment/implicit conversions from the element type.
This was an entirely gratuitous restriction.
@dnadlinger

Copy link
Copy Markdown
Author

Just noticed that this is still open. You probably want to merge this at some point to avoid accidentally making elements with elaborate conversions @trusted.

The existing documentation was also unnecessarily mysterious in places regarding "NEVER CHANGING CPU CORES." (I originally fixed the version in wekapp for the D memory model.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant