Compatibility for Thread._locks - #15
Open
thewilsonator wants to merge 1 commit into
Open
Conversation
Contributor
Author
|
Hmm, this doesn't work: https://issues.dlang.org/show_bug.cgi?id=19761 |
Contributor
|
The whole point of using this method was to grant us access to private members which we need in order to switch fibers not from within the Thread druntime module. The real solution to this is to create an advertised API in Thread for switching fibers, and have D's Fiber class use that instead of accessing private members of Thread (there is no reason for Fiber and Thread to share a module aside from this). This would allow Mecca to use public APIs for switching fibers. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See dlang/druntime#2519