fix add accessible name to icon button#386
Open
FlorianBoe wants to merge 1 commit into
Open
Conversation
Owner
|
Sorry I got a bit sidetracked with other Kirby development. Will try to add this in the next weeks. Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Nico 👋
Thank you for this helpful plugin!
Fixes #
In the overview, there are two icon buttons without an accessible name. This is a problem for screen reader users, but it’s also generally considered best practice.
Proposed Changes
The k-button component needs a title, which is used within the component for both the
titleand thearia-labelattribute.I have added the necessary translation strings.