Open
Conversation
Contributor
|
I think there are a few broader questions that needs to be discussed on Lighthouse before going through the details of this specific PR. |
Member
|
The lighthouse ticket that mentions this PR can be found here |
Member
|
The switch statement should be switch ($x) { } |
kasperg
pushed a commit
to kdb/alma
that referenced
this pull request
Mar 23, 2015
Avoid a notice when no absentPeriods have been set.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solves part of lighthouse ticket #1917 - extending note with debt types