Add arm to test matrix#2268
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This reverts commit 98df10b.
Greptile SummaryThis PR adds an ARM (
Confidence Score: 5/5The changes are safe to merge — they add a new CI runner and skip guards for a known-broken native extension on ARM, with no changes to production logic. The CI matrix expansion is straightforward and correctly uses startsWith to match both Ubuntu runner variants. The sqlite-vec skip logic is applied consistently through both the marker system (collection-time) and imperative fixture skips (runtime), correctly isolating only the sqlite-vec tests. The duplication of the skip predicate across three files was already noted in a prior review thread and does not represent a new defect here. No files require special attention. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[CI Matrix Job Start] --> B{matrix.os}
B -->|ubuntu-latest x 3.10-3.14| C[x86-64 Ubuntu Runner]
B -->|ubuntu-latest x 3.14t| D[x86-64 Ubuntu Runner free-threaded Python]
B -->|ubuntu-24.04-arm x 3.14| E[ARM64 Ubuntu Runner]
C --> F[Install portaudio startsWith ubuntu]
D --> F
E --> F
F --> G[uv sync + pytest]
G --> H{platform.machine == aarch64?}
H -->|Yes ARM runner| I[skipif_no_sqlite_vec tests skipped]
H -->|No x86-64| J[All tests run incl. sqlite-vec]
I --> K[sqlite_store fixture imperative pytest.skip]
I --> L[Class marker skipif_no_sqlite_vec collection-time skip]
Reviews (2): Last reviewed commit: "Merge branch 'main' into Dreamsorcerer-p..." | Re-trigger Greptile |
leshy
left a comment
There was a problem hiding this comment.
actually @Dreamsorcerer "skip if no sqlite vec" is a bit unclear on where this happens,
can we have standardized skip tag per OS? like this would have skip_arm tag? so that we know which OS can cover which functionality
We can, but this needs to be skipped in macos, so I was merging this skip. Can change to adding 2 skip markers if you prefer? |
leshy
left a comment
There was a problem hiding this comment.
don't want to block too much on details, can move and reassess, but yeah generally a preferece for per-os ignores on tests, since then we can easily see our support per OS, could we fix in the follow ups?
Fixes #2263.