Added support for Repeat Mode's to Image

[stringa]

I'm seeing scaling/rounding issues when using patterns to draw images. Most sprites don't need texture wrapping turned on, so we should just use drawImage when no repeat is desired.

I was seeing a lot of artifacts on Safari and what I believe to be rounding issues due to hierarchical concatenation of transforms.

Not sure if you are interested in this change, but I think it's pretty useful.

[tonistiigi]

This seems too CSS specific to me. Because there isn't a way to set background size + position I don't see a reason to add it. Currently it seems to be more like an optimization hint to the rendering engine. Am I correct?

If there are scaling/rounding issues that require it then sure we can add it but then I would like a test case before to see it this can be some other bug.

In no-dom branch there is a condition for detecting if the background repeats or not(for speed). We could use this condition to detect if drawImage should be used instead of a setter from the user. It needs some cleaning up but if you are willing to do this then this could be in master also.

[stringa]

Sure. I will take a look.
On Jan 2, 2014 12:40 AM, "Tõnis Tiigi" [email protected] wrote:

This seems too CSS specific to me. Because there isn't a way to set
background size + position I don't see a reason to add it. Currently it
seems to be more like an optimization hint to the rendering engine. Am I
correct?

If there are scaling/rounding issues that require it then sure we can add
it but then I would like a test case before to see it this can be some
other bug.

In no-dom branch there is a condition for detecting if the background
overflows or not(for speed). We could use this condition to detect if
drawImage should be used instead of a setter from the user. It needs some
cleaning up but if you are willing to do this then this could be in master
also.

—
Reply to this email directly or view it on GitHub.