Skip to content

fix(Popover): correct fallback offset value to 8px when no arrow #4931

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
olros wants to merge 2 commits into from
+6 −1
Closed

fix(Popover): correct fallback offset value to 8px when no arrow #4931

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
57a49e3
fix(Popover): correct fallback offset value to 8px when no arrow
olros May 28, 2026
5874af6
Update changeset
olros Jun 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/heavy-pots-knock.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@digdir/designsystemet-web": patch
---

**Popover, Dropdown, Tooltip, Suggestion**: Correct the fallback offset floating value to 8px when no arrow is present
2 changes: 1 addition & 1 deletion packages/web/src/popover/popover.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ function handleToggle(
strategy: 'absolute',
placement,
middleware: [
offset(arrowSize || 0), // Add space for arrow or default to 8px
offset(arrowSize || 8), // Add space for arrow or default to 8px
shift({
padding,
limiter: limitShift({ offset: { mainAxis: shiftLimit } }), // Prevent from shifing away from source
Expand Down