Repository navigation
Conversation
Break the runtime require cycles that bundlers such as Metro flag as "Require cycle ... can result in uninitialized values": - core: use `import type` for type-only imports and import values from their source module instead of a barrel (fixes InteractiveAdvertisingBureau#390). - cmpapi: EventListenerQueue no longer imports GetTCDataCommand at module evaluation time; GetTCDataCommand registers itself on load (fixes InteractiveAdvertisingBureau#348). Both changes are internal only and preserve the public API. Adds a regression test in core and cmpapi that fails on any circular dependency in the compiled CommonJS output. (cherry picked from commit 0293895)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Break the runtime require cycles that bundlers such as Metro flag as "Require cycle ... can result in uninitialized values":
import typefor type-only imports and import values from their source module instead of a barrel (fixes Cyclical dependency warning InteractiveAdvertisingBureau/iabtcf-es#390).Both changes are internal only and preserve the public API. Adds a regression test in core and cmpapi that fails on any circular dependency in the compiled CommonJS output.
(cherry picked from commit 0293895)