Fixes issues #1-4#5
Open
sehe wants to merge 13 commits into
Open
Conversation
This can be important. Also, realize that destruction order is the same in reverse.
Note that there is missin error handling as the TODO already indicated
Avoid non standard code to allow portability. Made the headers into a named struct and members. Reworded most _data accesses to use `headers()` accessor.
Graceful shutdown requires closing the hubconnection and any acceptor if
applicable. Only then will a join() complete.
Actually this needs bit more work, because one does not by default want
to cut operations in the middle of sending output.
I suggest giving `do_close` a bool flag `forced` to indicate whether
pending write operations (operations for which we own the initiative)
are to be forcibly interrupted.
Existing locations to invoke `do_close` in error conditions shall supply
`forced = true`. Other cases should default to `forced = false` so as to
make sure that simple client programs will work as expected:
```c++
msghub msghub(io_service);
msghub.connect("localhost", 1334);
msghub.publish("Publish", "new message");
//msghub.join(); // implied
```
Here the message should be expected to be delivered, regardless of
timings. Of course barring connectivity issues, in which case
`do_close(forced = true)` should happen because of the error condition.
Open
To use:
cmake .
make
make test
Run the example in separate terminals:
./examples/server
./examples/client
Somehow the runner was segfaulting with the CMake steps. Didn't want to find out why, instead used the default runner main with auto test suites/cases.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See the respective tickets for #1, #3 and #4
The fixes for #2 entail many separate commits, for which see the changes list.
Tests now run / still run respectively. Documentation has been updated.