raincloud: flip oasst1 to ok — #270 fixed#276
Merged
Conversation
The CsvExporter null-struct-row fix (render a fully-null nested Struct row as
an empty CSV cell instead of {"field":null,...}), merged in #275 (commit
70b7848), closes the oasst1 conformance gap tracked by #270.
Confirmed by re-running RaincloudConformanceIntegrationTest#conformancePerSlug
scoped to the hydrated corpus (forkCount=0): before the flip, oasst1's
gap-arm assertion fired "known gap gap:270 no longer reproduces" (the export
now succeeds and matches the parquet oracle exactly); after flipping the entry
to ok the whole 130-slug factory is green (Tests run: 130, Failures: 0),
proving the ok-arm assertMatchesParquetOracle path passes for oasst1.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CsvExporternull-struct-row fix (fix: render a null struct row as an empty CSV cell, not {"field":null,...} #275, commit70b78481) closes theoasst1conformance gap tracked by CsvExporter renders a null struct row as {"field":null,...} instead of an empty cell #270.RaincloudConformanceIntegrationTest#conformancePerSlugagainst the hydrated corpus: before the flip, oasst1's gap-arm assertion fired "known gap gap:270 no longer reproduces"; after flipping the entry took, the whole 130-slug factory is green (130 run, 0 failures) — confirming theassertMatchesParquetOraclepath passes for oasst1, not just the oldassertStillFailspath.Test plan
./mvnw verify -pl integration -am -Dit.test="RaincloudConformanceIntegrationTest#conformancePerSlug"— 130 run, 0 failures (corpus hydrated locally)🤖 Generated with Claude Code