Conversation
|
can anyone test this? |
| if p.usingItem { | ||
| p.tryChargeItem(usable, false) | ||
| return | ||
| } else if time.Since(p.serverChargedItem) <= time.Millisecond*100 { |
There was a problem hiding this comment.
Is there no way at all to distinguish the client wants to finish charging a crossbow vs. release it?
| p.handleUseContext(useCtx) | ||
| p.updateState() | ||
| if p.usingItem { | ||
| p.tryChargeItem(usable, false) |
There was a problem hiding this comment.
Is there even a reason to care about the client finishing the charge anymore if we are handling it on player tick? I believe players get ticked before the transactions executed by packet handlers are handled, so player tick would beat UseItem in most cases unless the client sends too early, in which case the charge finish would be rejected anyway.
But if the UseItem charge attempt does not get rejected, would there not be an issue of crossbow releases sometimes having an artificial delay of 100ms and sometimes not?
There was a problem hiding this comment.
idk if we should care about client finishing the charge, but I think it would be better to remove this option
I found that vanilla has a slight delay
There was a problem hiding this comment.
Ok we can see if any players end up complaining about that delay later then
|
can this get merged already i tested it out on 400+ms and worked perfectly fine |
|
this aged like fine wine xd |
|
@DaPigGuy what's your verdict? And have more people been able to test this to make sure it works properly? |
4 participants
No description provided.