Skip to content

feat(app-builder): add typed generator catalog - #135

Merged
kattsushi merged 22 commits into
feat/app-builder-reusable-generation-kernelfrom
feat/app-builder-typed-kernel-catalog
Aug 14, 2026
Merged

feat(app-builder): add typed generator catalog#135
kattsushi merged 22 commits into
feat/app-builder-reusable-generation-kernelfrom
feat/app-builder-typed-kernel-catalog

Conversation

@kattsushi

Copy link
Copy Markdown
Contributor

Closes #134

Part of #131. Depends on #133.

Summary

  • add schema-validated RenderContext and finite typed generator contracts
  • compose closed catalogs in deterministic dependency order
  • reject invalid contexts, dependency failures, duplicate identities, and post-construction graph mutation

Changes

File Change
packages/app-builder/generation/src/kernel.ts Define validated context, capability, generator, catalog, and typed failure contracts.
packages/app-builder/generation/src/catalog.ts Decode context and compose finite catalogs deterministically with fail-closed conflict checks.
packages/app-builder/generation/src/index.ts Export the public typed kernel surface.
packages/app-builder/generation/tests/kernel.test.ts Cover hostile contexts, graph ordering, catalog failures, immutability, and unsafe roots.

Test plan

  • pnpm nx run @effectify/app-builder-generation:test --skip-nx-cache — 23/23 passed
  • pnpm nx run @effectify/app-builder-contracts:test --skip-nx-cache — 67/67 passed
  • pnpm nx run @effectify/app-builder-generation:typecheck --skip-nx-cache
  • pnpm nx run @effectify/repo:format:check --skip-nx-cache
  • git diff --check
  • Scoped remediation validator passed

Contributor checklist

  • Linked an approved issue
  • Added exactly one type:* label
  • Tests included with the behavior
  • Conventional commit format
  • No Co-Authored-By trailers

@kattsushi kattsushi added the type:feature New feature work label Aug 11, 2026
@coderabbitai

coderabbitai Bot commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 72f8b496-f8b6-46d2-8492-497a782f34f3

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

refactor(app-builder): use declarative generation templates
feat(app-builder): prove installed CLI generation
feat(app-builder): preserve Todo v1 parity
feat(app-builder): materialize atomic Todo plans
feat(app-builder): add atomic Todo renderers
feat(app-builder): add generation surface adapters
@kattsushi
kattsushi marked this pull request as ready for review August 14, 2026 16:08
@kattsushi
kattsushi merged commit a45773a into feat/app-builder-reusable-generation-kernel Aug 14, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type:feature New feature work

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant