Skip to content

feat(app-builder): add closed CLI protocol - #122

Merged
kattsushi merged 34 commits into
feat/app-builder-golden-evolutionfrom
feat/app-builder-golden-cli-protocol
Aug 14, 2026
Merged

feat(app-builder): add closed CLI protocol#122
kattsushi merged 34 commits into
feat/app-builder-golden-evolutionfrom
feat/app-builder-golden-cli-protocol

Conversation

@kattsushi

@kattsushi kattsushi commented Aug 8, 2026

Copy link
Copy Markdown
Contributor

Closes #121

Tracker: #92

Chain Context

  • Strategy: feature-branch-chain
  • Current slice: PR 05 / Closed CLI Protocol
  • Base: feat/app-builder-golden-evolution at 65b8899cec6472fce29955aa9eeaf5ecd00d522a
  • Head: feat/app-builder-golden-cli-protocol at fb2313382fb02d6753b7b55d6003800ebbd8a06d
  • Out of scope: replay, nested E2E, showcase, Effect AI, MCP, marketplace, and arbitrary execution.
tracker (#92) -> PR 01 -> PR 02 -> PR 03 -> PR 04 -> 📍 PR 05 -> PR 06 -> PR 07 -> PR 08

Summary

  • Adds a closed, schema-decoded JSON protocol for the seven approved commands.
  • Preserves trusted plan behavior and returns closed typed results for later-slice commands.
  • Enforces stdin XOR input file, JSON/JSONL framing, stderr-only diagnostics, and stable exits.

Changes

File Change
packages/app-builder/cli/src/{main,protocol,commands}.ts Adds the closed protocol, dispatch map, and Node boundary.
packages/app-builder/cli/tests/protocol.test.ts Covers R09-R11, S16-S20, T1/T2.
openspec/changes/app-builder-golden-monorepo/tasks.md Marks only 5.1 and 5.2 complete.

Test Plan

  • pnpm nx test @effectify/app-builder-cli — 1 file / 5 tests passed.
  • Exact-parent pnpm nx affected --target=lint|typecheck|test|build --base=65b8899cec6472fce29955aa9eeaf5ecd00d522a --head=HEAD runs all passed.
  • Real built runNodeCli stdin/file harness proved JSON/JSONL, one terminal envelope, stderr separation, exit 0 success, and exit 2 rejection.
  • No shell scripts changed; shellcheck is not applicable.

Contributor Checklist

@kattsushi kattsushi added the type:feature New feature work label Aug 8, 2026
@coderabbitai

coderabbitai Bot commented Aug 8, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: d87723cf-64a1-49ae-b087-77e37a9f6471

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@kattsushi
kattsushi marked this pull request as ready for review August 8, 2026 19:44
refactor(app-builder): use declarative generation templates
feat(app-builder): prove installed CLI generation
feat(app-builder): preserve Todo v1 parity
feat(app-builder): materialize atomic Todo plans
feat(app-builder): add atomic Todo renderers
feat(app-builder): add generation surface adapters
@kattsushi
kattsushi merged commit 27dfa4a into feat/app-builder-golden-evolution Aug 14, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type:feature New feature work

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant