Skip to content

UI Fix and enhancement#499

Open
Klath123 wants to merge 1 commit intodevsecopsmaturitymodel:mainfrom
Klath123:main
Open

UI Fix and enhancement#499
Klath123 wants to merge 1 commit intodevsecopsmaturitymodel:mainfrom
Klath123:main

Conversation

@Klath123
Copy link
Contributor

Improve Dark Theme, Update model.yml to v4, and Fix Sidenav Issues

Summary

This PR introduces UI improvements and configuration updates to enhance the overall user experience and maintain consistency.


Changes Made

1. Improve Dark Theme

  • Enhanced color contrast for better readability.
  • Improved background and surface color consistency.
  • Refined text visibility across components.

2. Update model.yml to v4

  • Migrated configuration to version 4.
  • Ensured compatibility with the updated structure.

3. Remove Ribbon

  • Removed the ribbon component as it was already present in the sidenav.
  • Eliminated redundant UI elements for a cleaner layout.

4. Fix Sidenav Overflow on Scroll

  • Resolved the issue where the sidenav overflowed during scrolling.
  • Improved layout stability and responsiveness.

Demo Videos

Before

Screen.Recording.2026-02-24.085540.mp4

After

Screen.Recording.2026-02-24.090200.mp4

Please let me know if any additional refinements are needed.

Copy link
Collaborator

@vbakke vbakke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lots of good tidying. But I think #121212 it too harsh. It's almost completely black.

I know this is all about taste. But I always prefer a degree of light in my dark backgrounds. Even though it narrows the band of good contrasts for texts.

Especially on the heatmap page, the back hole in the middle is just sucking in my attention. The background should preferably not be notable. :)

Also, I don't understand --surface variables mention below. How do they differ from the existing --background variables?


//navbar
.mat-toolbar {
background-color: var(--surface-01) !important;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please avoid !important whenever possible

// Toolbar / Navbar
// ----------------------------------------------
.mat-toolbar {
background-color: var(--surface-01) !important;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same... !important

and more below

@Klath123
Copy link
Contributor Author

Klath123 commented Feb 25, 2026

Thanks for the review @vbakke ,
->I will remove the use of !important in this.
->I renamed the background variables to --surface-* in the dark theme to better represent different elevation levels (e.g., page background vs. toolbar vs. cards). My intention was to introduce a clearer semantic distinction between base backgrounds and elevated UI elements.
->I felt the current design was a little flat(as you said its all about taste). But I do agree with you that #121212 will be a bit harsh.
->I’ve prepared two alternative options with lighter dark tones and improved elevation contrast

1.Screenshot 2026-02-26 015528
2.Screenshot 2026-02-26 020043

Please have a look at these and suggest any needed changes. Happy to refine it further :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants