chore(SC-059): remove dead DataKey chunk variants; update ADR-0002#437
Merged
devEunicee merged 1 commit intoJun 27, 2026
Merged
Conversation
Removes four dead DataKey variants that were defined but never used: - MerchantPaymentChunk(Address, u32) - MerchantPaymentCount(Address) - PayerPaymentChunk(Address, u32) - PayerPaymentCount(Address) Also removes the duplicate MerchantPayments / PayerPayments / GlobalPaymentIndex entries that were left behind from the chunked-to-flat migration. Verified: grep confirms zero remaining references in storage.rs and lib.rs. ADR-0002 updated to document the chunked approach as a considered-and-rejected option and to note when/why the dead variants were removed. Closes devEunicee#237
|
@georgeefaith Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #237
Removes four
DataKeyvariants that were defined intypes.rsbut never written or read by any contract function (storage.rs, lib.rs):MerchantPaymentChunk(Address, u32)MerchantPaymentslistMerchantPaymentCount(Address)PayerPaymentChunk(Address, u32)PayerPaymentslistPayerPaymentCount(Address)Also removes the duplicate undocumented
MerchantPayments,PayerPayments, andGlobalPaymentIndexentries that were left alongside the documented ones from the same migration.Verification
Docs
ADR-0002 updated to: