fix(SC-036): enforce expiry in multisig sign/execute; handle expires_at==0#436
Merged
Merged
Conversation
…at==0 - sign_multisig_payment and execute_multisig_payment both checked expires_at but treated expires_at==0 as 'always expired' (timestamp > 0 is always true) - Fix: when expires_at==0, compute effective expiry as created_at + DefaultMultisigExpiry config value - Add test_multisig_zero_expires_at_applies_default_expiry covering: - signing succeeds within the default 24-hour window - execute returns PaymentExpired after the window Closes devEunicee#214
|
@georgeefaith Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #214
sign_multisig_paymentandexecute_multisig_paymentboth checkedexpires_atbut did not handle theexpires_at == 0case. Becauseenv.ledger().timestamp() > 0is always true, any multisig withexpires_at == 0would immediately returnPaymentExpired.Changes
lib.rssign_multisig_payment: whenms.expires_at == 0, compute effective expiry asms.created_at + DefaultMultisigExpirybefore the comparison.execute_multisig_payment: same fix.test.rstest_multisig_zero_expires_at_applies_default_expiry:PaymentExpiredThe existing
test_multisig_payment_expiryalready covers the expired-sign and expired-execute paths for a normally-setexpires_at.Testing