fix(SC-042): decrement pending_refund_amount on refund rejection, Add Loading Skeleton Screens#435
Merged
devEunicee merged 1 commit intoJun 27, 2026
Conversation
reject_refund already decrements pending_refund_amount via saturating_sub; adds the missing acceptance-criteria test: - asserts pending_refund_amount returns to 0 after rejection - asserts a re-initiated refund for the same amount succeeds Closes devEunicee#220
|
@georgeefaith Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
georgeefaith
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #220
Closes #242
reject_refundalready decrementspending_refund_amountviasaturating_subto prevent inflation. This PR adds the missing acceptance-criteria test to verify the behaviour end-to-end.Changes
test_reject_refund_decrements_pending_and_allows_reinitiatepending_refund_amountis 500 after initiationpending_refund_amountreturns to 0 after rejection (no underflow)Testing
Both
test_reject_refundandtest_reject_refund_decrements_pending_and_allows_reinitiatepass.