[opsiff]

Update kernel base to 6.18.58.

Summary by Sourcery

Update the kernel base to 6.18.58 and incorporate the associated upstream stability, correctness, and security fixes.

Bug Fixes:

• Fix races and resource-lifetime issues across networking, storage, USB, PCIe, filesystem, memory management, scheduling, and security subsystems.
• Improve kernel module integrity handling for compressed modules and strengthen related security policy checks.

Enhancements:

• Update the kernel base from 6.18.57 to 6.18.58 with upstream fixes and maintenance improvements across architecture, drivers, filesystems, networking, io_uring, scheduling, and security code.

Tests:

• Update VMA tests for the revised VMA-copying interface.

[sourcery-ai]

Reviewer's Guide

Updates the kernel base to 6.18.58 by changing the sublevel and importing a wide upstream stable-kernel fix set, with notable changes to device power management, driver teardown and concurrency, filesystem integrity and recovery, io_uring accounting, VMA handling, protocol lifetimes, scheduler hotplug behavior, and security measurement and policy paths.

Sequence diagram for synchronous iavf MAC address changes

sequenceDiagram
    participant User
    participant iavf_set_mac
    participant PF
    participant AdminQueue

    User->>iavf_set_mac: iavf_set_mac
    iavf_set_mac->>iavf_set_mac: iavf_set_mac_sync
    iavf_set_mac_sync->>PF: iavf_add_ether_addrs
    PF-->>AdminQueue: ADD_ETH_ADDR response
    iavf_set_mac_sync->>AdminQueue: iavf_poll_virtchnl_response
    AdminQueue->>iavf_set_mac_sync: iavf_virtchnl_completion
    alt response received
        iavf_set_mac_sync-->>User: success
    else timeout
        iavf_set_mac_sync-->>User: -EAGAIN
    end

Loading

Sequence diagram for compressed kernel module integrity checks

sequenceDiagram
    participant Loader as init_module_from_file
    participant Reader as kernel_read_file
    participant Decompressor as module_decompress
    participant IMA as security_kernel_post_read_file
    participant SELinux as selinux_kernel_read_file

    Loader->>Reader: kernel_read_file READING_MODULE_COMPRESSED
    Reader-->>Loader: compressed module data
    Loader->>Decompressor: module_decompress
    Decompressor-->>Loader: decompressed module
    Loader->>IMA: security_kernel_post_read_file READING_MODULE
    IMA->>SELinux: selinux_kernel_read_file
    SELinux-->>IMA: policy decision
    IMA-->>Loader: integrity result

Loading

Flow diagram for dm-integrity superblock validation on resume

flowchart TD
    Resume[dm_integrity_resume]
    Read[sync_rw_sb]
    Compare[superblock_changed]
    Restore[Restore ic->sb from ic->sb_copy]
    Error[dm_integrity_io_error]
    Writes[Update flags and write superblock]

    Resume --> Read
    Read --> Compare
    Compare -->|changed| Restore
    Restore --> Error
    Compare -->|unchanged| Writes

Loading

File-Level Changes

Change	Details	Files
Bumps the kernel base from 6.18.57 to 6.18.58 and incorporates a broad set of upstream fixes across architecture, drivers, filesystems, memory management, networking, security, scheduling, and io_uring.	Updates the kernel sublevel. Fixes architecture and virtualization behavior, including RISC-V executable-memory patch mapping and KVM memslot generation lookup. Improves AMD GPU/USB runtime power ordering, Xe I2C teardown, ERDMA xarray IRQ safety, UFS completion handling, PCIe link error reporting, SPI IRQ cleanup, and multiple network drivers. Hardens filesystem and storage behavior in dm-integrity, FAT, CIFS, XFS, NFS, SMB server, and SCSI changer paths. Corrects io_uring memory accounting, module loading and compressed-module security measurement, DAMON lifecycle handling, mremap/VMA operations, and kexec handover memory freeing. Fixes networking and Bluetooth/USB lifetime, teardown, protocol, and receive-buffer handling issues. Updates SELinux, IMA, IPE, kernel-read identifiers, and related security policy behavior.	Makefile arch/riscv/kernel/patch.c arch/x86/kvm/x86.h drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c drivers/gpu/drm/amd/pm/swsmu/inc/amdgpu_smu.h drivers/gpu/drm/amd/pm/swsmu/smu14/smu_v14_0_0_ppt.c drivers/gpu/drm/xe/xe_i2c.c drivers/infiniband/hw/erdma/erdma_main.c drivers/infiniband/hw/erdma/erdma_verbs.c drivers/md/dm-integrity.c drivers/net/ethernet/intel/iavf/iavf.h drivers/net/ethernet/intel/iavf/iavf_main.c drivers/net/ethernet/intel/iavf/iavf_virtchnl.c drivers/net/ethernet/microsoft/mana/mana_bpf.c drivers/net/ethernet/microsoft/mana/mana_en.c drivers/net/ethernet/xilinx/xilinx_axienet.h drivers/net/ethernet/xilinx/xilinx_axienet_main.c drivers/net/wireless/ath/ath9k/wmi.c drivers/net/wireless/ath/ath9k/wmi.h drivers/pci/controller/dwc/pcie-designware.c drivers/scsi/ch.c drivers/spi/spi-mpc52xx.c drivers/ufs/core/ufs-mcq.c drivers/ufs/core/ufshcd.c drivers/usb/gadget/function/f_hid.c drivers/usb/misc/iowarrior.c fs/fat/dir.c fs/nfsd/nfs4proc.c fs/smb/client/inode.c fs/smb/server/smb2pdu.c fs/xfs/libxfs/xfs_attr_leaf.c fs/xfs/libxfs/xfs_attr_leaf.h fs/xfs/libxfs/xfs_da_btree.c fs/xfs/libxfs/xfs_da_btree.h fs/xfs/xfs_attr_inactive.c include/linux/damon.h include/linux/kernel_read_file.h include/linux/skmsg.h include/net/bluetooth/rfcomm.h include/net/mana/mana.h io_uring/io_uring.c io_uring/kbuf.c io_uring/memmap.c io_uring/memmap.h io_uring/register.c io_uring/zcrx.c kernel/kexec_handover.c kernel/module/main.c kernel/sched/ext.c kernel/sched/sched.h mm/damon/core.c mm/mremap.c mm/vma.c mm/vma.h net/bluetooth/rfcomm/core.c net/ipv4/tcp_bpf.c net/ipv6/ip6_gre.c net/rose/af_rose.c net/rose/rose_timer.c security/integrity/ima/ima.h security/integrity/ima/ima_appraise.c security/integrity/ima/ima_main.c security/integrity/ima/ima_policy.c security/ipe/hooks.c security/selinux/hooks.c security/selinux/selinuxfs.c tools/testing/vma/vma.c

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[deepin-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from opsiff. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• deepin/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[sourcery-ai]

Hey - I've found 2 issues

Prompt for AI Agents

Please address the comments from this code review:

## Individual Comments

### Comment 1
<location path="security/selinux/selinuxfs.c" line_range="354-363" />
<code_context>

-	BUG_ON(filp->private_data);
-
-	mutex_lock(&selinux_state.policy_mutex);
-
 	rc = avc_has_perm(current_sid(), SECINITSID_SECURITY,
 			  SECCLASS_SECURITY, SECURITY__READ_POLICY, NULL);
 	if (rc)
-		goto err;
-
-	rc = -EBUSY;
-	if (fsi->policy_opened)
-		goto err;
+		return rc;

-	rc = -ENOMEM;
 	plm = kzalloc(sizeof(*plm), GFP_KERNEL);
 	if (!plm)
-		goto err;
+		return -ENOMEM;

+	mutex_lock(&selinux_state.policy_mutex);
 	rc = security_read_policy(&plm->data, &plm->len);
 	if (rc)
 		goto err;
-
 	if ((size_t)i_size_read(inode) != plm->len) {
 		inode_lock(inode);
 		i_size_write(inode, plm->len);
 		inode_unlock(inode);
 	}
-
-	fsi->policy_opened = 1;
+	mutex_unlock(&selinux_state.policy_mutex);

 	filp->private_data = plm;
</code_context>
<issue_to_address>
**Repeated policy opens exhaust kernel memory**

When a process granted SELinux policy-read permission repeatedly opens the policy file and keeps the descriptors open, `sel_open_policy()` calls `security_read_policy()` for each open, which allocates a separate `vmalloc_user()` policy image; `sel_release_policy()` keeps that image until the fd closes. Repeated opens can therefore exhaust kernel memory and destabilize the host.

Bound the number of active policy snapshots or otherwise account and cap their aggregate memory.
</issue_to_address>

### Comment 2
<location path="drivers/gpu/drm/amd/pm/swsmu/smu14/smu_v14_0_0_ppt.c" line_range="1698" />
<code_context>
+		/* Create device link: USB (consumer) depends on GPU (supplier) */
+		link = device_link_add(&usb_pdev->dev, &gpu_pdev->dev,
+				       DL_FLAG_STATELESS | DL_FLAG_PM_RUNTIME);
+		if (link) {
+			smu->usb_power_link = link;
+			drm_info(adev_to_drm(adev), "USB controller %s D0 power state depends on %s\n",
</code_context>
<issue_to_address>
**USB resume dependency is missing**

When device-link creation fails for a matching xHCI controller, `device_link_add()` returns `NULL`, but the helper reports success without recording that the dependency is missing, so initialization proceeds and USB can resume before the GPU.

Propagate device-link creation failure so initialization does not proceed without the USB-to-GPU dependency.
</issue_to_address>

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

[sourcery-ai]

🟡 Medium · Repeated policy opens exhaust kernel memory

When a process granted SELinux policy-read permission repeatedly opens the policy file and keeps the descriptors open, sel_open_policy() calls security_read_policy() for each open, which allocates a separate vmalloc_user() policy image; sel_release_policy() keeps that image until the fd closes. Repeated opens can therefore exhaust kernel memory and destabilize the host.

Bound the number of active policy snapshots or otherwise account and cap their aggregate memory.

Prompt for AI agents

In `security/selinux/selinuxfs.c` at lines 354-363:

**Repeated policy opens exhaust kernel memory**

When a process granted SELinux policy-read permission repeatedly opens the policy file and keeps the descriptors open, `sel_open_policy()` calls `security_read_policy()` for each open, which allocates a separate `vmalloc_user()` policy image; `sel_release_policy()` keeps that image until the fd closes. Repeated opens can therefore exhaust kernel memory and destabilize the host.

Bound the number of active policy snapshots or otherwise account and cap their aggregate memory.

[sourcery-ai]

🟡 Medium · USB resume dependency is missing

When device-link creation fails for a matching xHCI controller, device_link_add() returns NULL, but the helper reports success without recording that the dependency is missing, so initialization proceeds and USB can resume before the GPU.

Propagate device-link creation failure so initialization does not proceed without the USB-to-GPU dependency.

Prompt for AI agents

In `drivers/gpu/drm/amd/pm/swsmu/smu14/smu_v14_0_0_ppt.c` at line 1698:

**USB resume dependency is missing**

When device-link creation fails for a matching xHCI controller, `device_link_add()` returns `NULL`, but the helper reports success without recording that the dependency is missing, so initialization proceeds and USB can resume before the GPU.

Propagate device-link creation failure so initialization does not proceed without the USB-to-GPU dependency.

[Copilot]

🟡 Changes recommended

Unresolved critical issues allow truncated WMI replies to copy uninitialized data, GPU teardown to use a freed device link, and module appraisal to approve bytes using a replacement file’s cached digest.

8 open issues

• Avoid deleting a stale USB power device link · New
• Validate USB WMI response length before copying payload · New
• Prevent inode writes during module decompression and appraisal · New
• Require a non-NULL shared PCIe root port · New
• Wait for the requested MAC operation to complete · New
• Rollback only this call's MAC filter changes · New
• Refresh the readdir-size timestamp after successful truncate · New
• Preserve LoadPin exclusion for compressed modules · New

What changed in this PR

Updates Deepin’s kernel base from 6.18.57 to 6.18.58, integrating upstream maintenance across core kernel subsystems and drivers.

Changes:

• Updates compressed-module integrity handling and security hooks.
• Addresses resource lifetimes, concurrency, memory accounting, and filesystem consistency.
• Revises supporting interfaces and adapts VMA tests.

File	Description
tools/​testing/​vma/​vma.c	Adapts tests to the extended VMA-copy interface.
security/​selinux/​selinuxfs.c	Allows concurrent policy opens with per-file snapshots.
security/​selinux/​hooks.c	Handles compressed-module reads.
security/​ipe/​hooks.c	Applies module policy to compressed modules.
security/​integrity/​ima/​ima.h	Extends the appraisal interface with execution-check context.
security/​integrity/​ima/​ima_policy.c	Enables module signatures and blacklist checks in secure-boot rules.
security/​integrity/​ima/​ima_main.c	Supports deferred module appraisal and execution-check context.
security/​integrity/​ima/​ima_appraise.c	Uses explicit execution-check context for audit messages.
net/​rose/​rose_timer.c	Marks pending sockets before destruction.
net/​rose/​af_rose.c	Adds pending-socket references and teardown synchronization.
net/​ipv6/​ip6_gre.c	Removes the ERSPAN destination-MTU update.
net/​ipv4/​tcp_bpf.c	Includes ordinary TCP data in receive-queue accounting.
net/​bluetooth/​rfcomm/​core.c	Moves connection setup outside the RFCOMM mutex.
mm/​vma.h	Updates VMA-copy and split declarations.
mm/​vma.c	Prevents source self-merges when retaining mappings.
mm/​mremap.c	Prepares locked mappings for remapping without unmapping.
mm/​damon/​core.c	Coordinates walk requests with monitoring shutdown.
Makefile	Sets the kernel sublevel to 58.
kernel/​sched/​sched.h	Documents another scheduler locking exception.
kernel/​sched/​ext.c	Keeps tasks runnable during CPU offlining.
kernel/​module/​main.c	Adds post-decompression security appraisal.
kernel/​kexec_handover.c	Matches page allocation with page-based freeing.
io_uring/​zcrx.c	Passes explicit users for memory accounting.
io_uring/​register.c	Separates ring allocation from charged memory regions.
io_uring/​memmap.h	Updates memory-region accounting interfaces.
io_uring/​memmap.c	Makes user memory accounting explicit.
io_uring/​kbuf.c	Exempts provided-buffer rings from memlock accounting.
io_uring/​io_uring.c	Exempts submission and completion rings from memlock accounting.
include/​net/​mana/​mana.h	Makes XDP MTU limits account for device headroom.
include/​net/​bluetooth/​rfcomm.h	Defines a flag for closure during connection setup.
include/​linux/​skmsg.h	Removes the superseded receive-length helper.
include/​linux/​kernel_read_file.h	Adds a compressed-module read identifier.
include/​linux/​damon.h	Adds walk-request shutdown state.
fs/​xfs/​xfs_attr_inactive.c	Revises attribute-tree teardown for crash consistency.
fs/​xfs/​libxfs/​xfs_da_btree.h	Declares the attribute-node entry-removal helper.
fs/​xfs/​libxfs/​xfs_da_btree.c	Shares node-entry removal with attribute teardown.
fs/​xfs/​libxfs/​xfs_attr_leaf.h	Declares the leaf-reinitialization helper.
fs/​xfs/​libxfs/​xfs_attr_leaf.c	Adds empty-leaf reinitialization.
fs/​smb/​server/​smb2pdu.c	Accounts for compound-response offsets in authentication buffers.
fs/​smb/​client/​inode.c	Moves truncate timestamps before server requests.
fs/​nfsd/​nfs4proc.c	Preserves callback state identifiers for asynchronous copies.
fs/​fat/​dir.c	Honors end-of-directory markers during traversal.
drivers/​usb/​misc/​iowarrior.c	Reference-counts device state across open and disconnect.
drivers/​usb/​gadget/​function/​f_hid.c	Reports character-device allocation failure correctly.
drivers/​ufs/​core/​ufshcd.c	Drains completion queues before forced command completion.
drivers/​ufs/​core/​ufs-mcq.c	Processes completions without accessing disabled-controller registers.
drivers/​spi/​spi-mpc52xx.c	Corrects interrupt-allocation failure cleanup.
drivers/​scsi/​ch.c	Releases temporary SCSI device references.
drivers/​pci/​controller/​dwc/​pcie-designware.c	Distinguishes PCIe link-startup failure states.
drivers/​net/​wireless/​ath/​ath9k/​wmi.h	Removes response-status storage.
drivers/​net/​wireless/​ath/​ath9k/​wmi.c	Removes short-response validation and error propagation.
drivers/​net/​ethernet/​xilinx/​xilinx_axienet.h	Adds receive-submission locking state and documentation.
drivers/​net/​ethernet/​xilinx/​xilinx_axienet_main.c	Synchronizes DMA teardown and reclaims remaining buffers.
drivers/​net/​ethernet/​microsoft/​mana/​mana_en.c	Includes network-device headroom in receive-buffer sizing.
drivers/​net/​ethernet/​microsoft/​mana/​mana_bpf.c	Uses configured receive headroom for XDP.
drivers/​net/​ethernet/​intel/​iavf/​iavf.h	Declares synchronous response-polling interfaces.
drivers/​net/​ethernet/​intel/​iavf/​iavf_virtchnl.c	Adds response polling and filter-send error handling.
drivers/​net/​ethernet/​intel/​iavf/​iavf_main.c	Polls synchronously for MAC-address changes.
drivers/​md/​dm-integrity.c	Validates superblock geometry on resume.
drivers/​infiniband/​hw/​erdma/​erdma_verbs.c	Uses interrupt-safe XArray operations.
drivers/​infiniband/​hw/​erdma/​erdma_main.c	Configures interrupt-safe XArray locking.
drivers/​gpu/​drm/​xe/​xe_i2c.c	Stops notifications and work before client teardown.
drivers/​gpu/​drm/​amd/​pm/​swsmu/​smu14/​smu_v14_0_0_ppt.c	Creates an xHCI-to-GPU power dependency.
drivers/​gpu/​drm/​amd/​pm/​swsmu/​inc/​amdgpu_smu.h	Adds power-dependency state and callbacks.
drivers/​gpu/​drm/​amd/​pm/​swsmu/​amdgpu_smu.c	Integrates power-dependency setup and teardown.
arch/​x86/​kvm/​x86.h	Uses vCPU-specific memory-slot generations for MMIO caching.
arch/​riscv/​kernel/​patch.c	Revises physical-address mapping for executable-memory patching.

_{Review effort: Balanced}