[Deepin-Kernel-SIG] [linux 6.18.y] [FROMLIST] dmaengine: qcom: gpi: set DMA_PRIVATE capability

[Avenger-285714]

The GPI DMA controller is only responsible for QUP peripherals, and cannot work as a general-purpose DMA accelerator.

Set DMA_PRIVATE capability for it.

This fixes error messages about GPI being shown when an async-tx consumer is loaded.

Fixes: 5d0c353 ("dmaengine: qcom: Add GPI dma driver")

Link: https://lore.kernel.org/all/20260602070344.3707256-1-zhengxingda@iscas.ac.cn/
Suggested-by: Icenowy Zheng zhengxingda@iscas.ac.cn

Summary by Sourcery

Bug Fixes:

• Prevent spurious error messages and misuse by marking the Qualcomm GPI DMA controller with the DMA_PRIVATE capability instead of exposing it as a general-purpose DMA engine.

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Marks the Qualcomm GPI DMA engine as a private, non-generic DMA provider by adding the DMA_PRIVATE capability flag during probe, ensuring it is only used by its intended QUP peripheral clients and eliminating spurious async-tx related error messages.

Flow diagram for setting DMA_PRIVATE in gpi_probe

flowchart TD
    A[gpi_probe] --> B[dma_cap_zero gpi_dev_dma_device_cap_mask]
    B --> C[dma_cap_set DMA_SLAVE gpi_dev_dma_device_cap_mask]
    C --> D[dma_cap_set DMA_PRIVATE gpi_dev_dma_device_cap_mask]

Loading

File-Level Changes

Change	Details	Files
Mark the Qualcomm GPI DMA engine as DMA-private so it is not used as a generic async-tx DMA provider.	Extend the GPI DMA device capability mask to include DMA_PRIVATE in addition to DMA_SLAVE during probe initialization Rely on the DMA engine core to skip advertising the GPI controller to generic async-tx consumers, preventing unrelated clients from attempting to use it	drivers/dma/qcom/gpi.c

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[deepin-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from avenger-285714. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• deepin/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[sourcery-ai]

Hey - I've reviewed your changes and they look great!

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[Copilot]

Pull request overview

Marks the Qualcomm GPI DMA controller as a private DMA engine so it won’t be treated as a general-purpose async-tx DMA provider, preventing spurious error messages and accidental consumer binding. This aligns the driver’s advertised capabilities with its intended use (QUP peripherals only).

Changes:

• Add DMA_PRIVATE to the GPI DMAengine capability mask during probe.
• Keep DMA_SLAVE capability while restricting generic allocator visibility via DMA_PRIVATE.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.