Draft
Conversation
Member
mofojed
commented
Feb 4, 2026
mofojed
commented
- feat(ag-grid): add support for AdvancedFilterModel
- feat(ag-grid): Add AdvancedFilterModel parsing support
- WIP fix for Dockerfile and for AgGrid props overriding
Add support for AG Grid's AdvancedFilterModel which allows complex filter expressions with nested AND/OR logic across multiple columns. - Add isAdvancedFilterModel() type guard to identify advanced filters - Add parseAdvancedFilterModel() to recursively parse nested filter structures - Add parseAdvancedColumnFilter() to handle text, number, date, boolean, and object filter types - Support unlimited nesting depth of join conditions - Add comprehensive unit tests covering simple, nested, and deeply nested filters - All 47 tests passing with full type safety
- Add parseAdvancedFilterModel() to handle nested join conditions (AND/OR) - Add parseAdvancedColumnFilter() for text, number, date, boolean, object filters - Add isAdvancedFilterModel() type guard - Integrate AdvancedFilterModel in DeephavenViewportDatasource - Add AdvancedFilterModule to grid modules - Add comprehensive unit tests (47 passing) - Add e2e test structure for advanced filters Note: AG Grid's Advanced Filter UI is not compatible with Viewport Row Model. The parsing implementation is complete and functional, but the UI button will not appear. Waiting on AG Grid support for potential workarounds.
|
Pull Request titles must follow the Conventional Commits specification. Details: |
- Still needs AG-16656 from AG Grid: https://ag-grid.com/pipeline/
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.