Fix PCEN preprocessor and improve checkpoint config merging - #127
Merged
Conversation
- Fix LibrosaPcen: accept hop_length param (backward compat with n_mels), handle torch.Tensor input, squeeze singleton dims to prevent 5D tensor crash, update deprecated librosa.core.pcen to librosa.pcen - Add max_freq merging from checkpoint in merge_with_checkpoint() - Add PCEN preprocessor config (_preprocessor_with_pcen.yaml) - Add max_center_freq to BandStopFilter augmentation config - Add optional max_freq field to config validator Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…d for inference)
The max_center_freq references ${data.max_freq} which does not exist in
default data configs. This field is only relevant during training, not
inference, so removing it avoids breaking existing configs.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
mosheman5
approved these changes
Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Context
The Amber dolphin models (echo, whistle) use a Spectrogram → PCEN preprocessor chain. These models failed on inference due to:
All 4 Amber models (barks, echo, buzz, whistle) verified working on this branch with identical outputs to client/amber.
Test plan