Remove exposed ports from dev docker compose config#1779
Open
encounter wants to merge 1 commit intodecompme:mainfrom
Open
Remove exposed ports from dev docker compose config#1779encounter wants to merge 1 commit intodecompme:mainfrom
encounter wants to merge 1 commit intodecompme:mainfrom
Conversation
Collaborator
|
Hmm I'm not super keen on this change as I find it's handy to be able to directly access the processes (without going through nginx), and sticking nginx on 8080 means you can't just connect to http://localhost |
Collaborator
|
.. but I guess commenting them out (rather than removing entirely) would be a happy medium? Could you update the DOCKER.md to reflect the nginx port change |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes unnecessarily exposed ports from the dev docker-compose.yml. Since the application communicates with these services using the internal docker network, they aren't necessary to be exposed on the host. This avoids port conflicts with frequently-used ports. Additionally, this makes the nginx service bind to port
8080, which matches the port you'd use to access the site if using regularyarn dev.For compatibility with non-Docker container engines, explicitly specifies
docker.io/library/prefix for container image refs.