Conversation
mkst
reviewed
Sep 21, 2025
mkst
reviewed
Sep 21, 2025
mkst
reviewed
Sep 21, 2025
mkst
reviewed
Dec 14, 2025
mkst
reviewed
Dec 14, 2025
| try: | ||
| platforms.from_id(platform) | ||
| platform = cromper.get_platform_by_id(platform_id) | ||
| except Exception: |
Collaborator
There was a problem hiding this comment.
TODO: except CompilerError (or CromperError if we create it) which is slightly different to the validation error
mkst
reviewed
Dec 14, 2025
mkst
reviewed
Dec 14, 2025
backend/coreapp/views/scratch.py
Outdated
| if not platform: | ||
| platform = compiler.platform | ||
| cromper_client = get_cromper_client() | ||
| compiler = cromper_client.get_compiler_by_id(data["compiler"]) |
mkst
reviewed
Dec 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(this is currently unfinished and is in draft state)
This PR adds a new entirely separate service for handling the various processes involves in running the site: assembling, compiling, diffing, and running decompilers.
The backend still talks to this service directly, as well as the frontend server, but now the client can also talk directly to this server to do decompilation tasks, incremental compilations, etc.
There's several reasons we are separating these into a separate service:
Todo:
/platformendpoint to fetch platform data from cromper (or update api.ts to be able to call cromper?)